Last modified: 2013-01-26 04:01:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25750, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23750 - &redirects doesn't work properly with prop=imageinfo
&redirects doesn't work properly with prop=imageinfo
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.17.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Bryan Tong Minh
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-01 15:15 UTC by Roan Kattouw
Modified: 2013-01-26 04:01 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (801 bytes, patch)
2010-06-23 18:31 UTC, John Du Hart
Details

Description Roan Kattouw 2010-06-01 15:15:51 UTC
Per mailing list post:


http://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&titles=File:Liberia%20court%20of%20arms.png&iiprop=timestamp%7Curl%7Csize%7Cdimensions%7Cmime%7Cmetadata&redirects&format=xmlfm&iiurlwidth=128&iiurlheight=128

<?xml version="1.0"?>
<api>
  <query>
    <redirects>
      <r from="File:Liberia court of arms.png" to="File:Coat of arms of Liberia.png" />
    </redirects>
    <pages>
      <page pageid="23044582" ns="6" title="File:Coat of arms of Liberia.png" imagerepository="" />
    </pages>
  </query>
</api>


http://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&titles=File:Coat%20of%20arms%20of%20Liberia.png&iiprop=timestamp%7Curl%7Csize%7Cdimensions%7Cmime%7Cmetadata&redirects&format=xmlfm&iiurlwidth=128&iiurlheight=128

<?xml version="1.0"?>
<api>
  <query>
    <pages>
      <page pageid="23044582" ns="6" title="File:Coat of arms of Liberia.png" imagerepository="local">
        <imageinfo>
          <ii timestamp="2009-06-01T14:04:00Z" size="14121" width="200" height="211" thumburl="http://upload.wikimedia.org/wikipedia/en/thumb/1/12/Coat_of_arms_of_Liberia.png/121px-Coat_of_arms_of_Liberia.png" thumbwidth="121" thumbheight="128" url="http://upload.wikimedia.org/wikipedia/en/1/12/Coat_of_arms_of_Liberia.png" descriptionurl="http://en.wikipedia.org/wiki/File:Coat_of_arms_of_Liberia.png" metadata="" mime="image/png" />
        </imageinfo>
      </page>
    </pages>
  </query>
</api>
Comment 1 John Du Hart 2010-06-23 18:31:28 UTC
Created attachment 7502 [details]
Proposed patch
Comment 2 Roan Kattouw 2010-07-21 10:29:25 UTC
Interestingly, I cannot reproduce this in trunk. Presumably the FileRepo code got fixed to handle redirects properly.
Comment 3 magog.the.ogre 2011-12-27 23:26:27 UTC
I'm reopening this bug, because it's causing my bot to get grumpy.

Here's the URL:
http://commons.wikimedia.org/w/api.php?action=query&redirects&titles=File:Wkwikilogo.jpg|File:WomanofTheYearScreenshot.jpg&prop=imageinfo|templates&iiprop=sha1|mime|user|comment|url|size|timestamp|bitdepth&iilimit=max&tllimit=max

I've included templates in the example above in order to show that other functions work properly; I've also tested the revisions prop, and it works properly, at least AFAIK.

You'll notice two issues with the listing of File:Woman of the Year publicity photograph.jpg:
1) It does not include repository information
2) It doesn't include any imageinfo.

This is bad, because it's the API isn't advertised to malfunction here. And really, there is no reason to do so.
Comment 4 magog.the.ogre 2012-01-09 05:50:14 UTC
apparently no one views bugs unless they're marked as new...
Comment 5 Andre Klapper 2012-05-08 09:19:51 UTC
Can somebody please review the patch in comment 1 and afterwards replace the "patch-need-review" keyword by "patch-reviewed"?
Comment 6 Bryan Tong Minh 2012-12-24 22:43:21 UTC
I think this is also fixed by I748e5223
Comment 7 Bryan Tong Minh 2012-12-24 22:44:09 UTC
That is, I27485bba.
Comment 8 Liangent 2013-01-26 04:01:21 UTC
I27485bba has been merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links