Last modified: 2010-05-11 22:31:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25461, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23461 - Normalise usage of parameter names in parameter descriptions
Normalise usage of parameter names in parameter descriptions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-10 15:33 UTC by Sam Reed (reedy)
Modified: 2010-05-11 22:31 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-05-10 15:33:47 UTC
Per irc, we should normalise the style. In this case, it seems appending the module prefix is probably better.

Some are hardcoded with the prefix, some use fields etc.

<Reedy> RoanKattouw, in ApiQueryRevisions, we use the literal rvsections in a description... Every other param references is minus prefix... Presume it should be removed?
<RoanKattouw> This is probably inconsistent across the API as well. Let's pick one and stick with it
<Reedy> it's that, or do something with a prefux
<RoanKattouw> Maybe see which style is the most frequently used one. I have no idea
<Reedy> RoanKattouw, I suspect, if we're going to normalise it to using the prefix, we shouldn't hard code in.. Incase we inherit from modules etc etc?
<RoanKattouw> Reedy: Yes, and for multi-mode modules. So that means {$this->getModulePrefix()} or whatever the name is all over
<RoanKattouw> See ApiQueryBacklinks
<Reedy> Mmmm
<RoanKattouw> Or do $p = $this->getModulePrefix(); and use {$p} , probably nicer
Comment 1 Sam Reed (reedy) 2010-05-11 22:31:37 UTC
r66232

Probably not perfect, but somewhere near

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links