Last modified: 2014-11-17 10:36:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25354, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23354 - CharInsert: Split displayed text from inserted code
CharInsert: Split displayed text from inserted code
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CharInsert (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-30 13:09 UTC by Subfader
Modified: 2014-11-17 10:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
add custom label on charinsert (1.01 KB, patch)
2010-06-24 16:31 UTC, Johan Euphrosine
Details
add custom label on charinsert test case (543 bytes, text/plain)
2010-06-24 17:04 UTC, Johan Euphrosine
Details

Description Subfader 2010-04-30 13:09:40 UTC
As the title says, the displayed text for CharInsert should be splitted from the inserted code. 
E.g.: "includeonly" inserts <includeonly></includeonly>

It would also be awesome if multirow text could be inserted like templates and tables.
Comment 1 Johan Euphrosine 2010-06-24 16:31:06 UTC
Created attachment 7510 [details]
add custom label on charinsert
Comment 2 Johan Euphrosine 2010-06-24 16:32:23 UTC
Feel free to review this patch for inclusion in CharInsert extensions, it allows to customized the link label by passing a "label" argument to charinsert tag, example:

<charinsert label="foo">bar</charinsert>
Comment 3 Johan Euphrosine 2010-06-24 16:38:04 UTC
Please tell me if it needs additional work.
Comment 4 Johan Euphrosine 2010-06-24 17:04:00 UTC
Created attachment 7511 [details]
add custom label on charinsert test case

Here is a test case that validated submitted patch behaviour.
Comment 5 Subfader 2011-02-27 15:01:26 UTC
Sorry, had not time back then and now remembered this. The patch works fine (without the test case). Cheers!
Comment 6 p858snake 2011-04-30 00:09:34 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 7 Subfader 2011-06-08 21:23:47 UTC
How can I add line breaks using your patch? E.g. to insert

== Healine ==
Text.

== Another Headline ==
Comment 8 Bugmeister Bot 2011-08-19 19:12:26 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 9 Sumana Harihareswara 2011-11-14 16:38:08 UTC
Johan, I'm sorry for the wait.  I'm marking this bug with "need-review" to signal to developers that there's code here awaiting review.  Thank you for your patch and test case.
Comment 10 Sumana Harihareswara 2012-05-16 19:29:22 UTC
Johan, does your patch still apply?

I recommend that you get a developer access account https://www.mediawiki.org/wiki/Developer_access so that you can commit your patches directly into the source control system in the future -- in fact, you could update and submit this patch, and get it reviewed faster.  I'm sorry for the delay.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links