Last modified: 2012-05-05 18:44:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25304, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23304 - do not list CR/LF only changes in diff
do not list CR/LF only changes in diff
Status: RESOLVED DUPLICATE of bug 20310
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-23 21:52 UTC by merl
Modified: 2012-05-05 18:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description merl 2010-04-23 21:52:51 UTC 
If you create a filter that should deny adding special lines with e.g. "added_lines rlike 'x'" and 'x' is the content of the last line and s.b. adds some more lines at the end the filter is matching because CR/LF was added. So removed_lines contains 'x' and added lines contains 'x<LF>'

I think changes only containing CR/LF should not be added to the diff because it make simply add_lines filter more complicated because you have to extend the query for checking removed_lines containing the line without LF.
Comment 1 John Mark Vandenberg 2011-04-28 09:24:00 UTC 
Can you give an example?
The AbuseFilter diff variables are built using the standard wfDiff function, which also is also used for normal diffs available from the history navigation screen.  Maybe this bug needs to be changed to mediawiki Component 'History/Diffs'
Comment 2 seth 2011-07-25 19:43:29 UTC 
mayby this is the same bug as bug 19716
Comment 3 db [inactive,noenotif] 2012-05-05 18:44:55 UTC 

*** This bug has been marked as a duplicate of bug 20310 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links