Last modified: 2010-04-17 04:07:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25098, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23098 - baseRevId should carry over preview/show changes
baseRevId should carry over preview/show changes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-08 19:06 UTC by Umherirrender
Modified: 2010-04-17 04:07 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-04-08 19:06:18 UTC 
When do an "undo" and than use the preview or show changes button the request lost the information about the undo, so Extension cannot use this information, when save the page. Please reassigned the undo and undoafter parameter als hidden fields, so Extension can use this information.

This is relevant for FlaggedRevs, because the Extension fails on autosighted undo edits (see FlaggedRevsView.php, function addRevisionIDField for more details), after preview.

Thanks.
Comment 1 Umherirrender 2010-04-09 14:23:56 UTC 
Change to FlaggedRevs, because this can be fixed by reassign the old values of 'baseRevId' and 'undidRev' in FlaggedRevs and not set the fields on new values.

There is no need to do that with the undo fields, because the undo parameter are only need for get the content, not more.
Comment 2 Aaron Schulz 2010-04-17 04:07:31 UTC 
Done in r65153.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links