Last modified: 2011-08-23 21:40:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25049, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23049 - <pages> and odd behaviour of fromsection and tosection
<pages> and odd behaviour of fromsection and tosection
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Beau
: patch, patch-reviewed
Depends on: 23407
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-05 06:44 UTC by Beau
Modified: 2011-08-23 21:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A patch fixing fromsection (4.02 KB, patch)
2010-05-05 18:35 UTC, Beau
Details
Updated version that applies to r93993 (1.56 KB, patch)
2011-08-20 08:49 UTC, Beau
Details

Description Beau 2010-04-05 06:44:24 UTC
Let's assume I have two pages. A page "1" with sections: A, B, C; and a page "2" with sections: D, E, F.

The tag <pages from="1" fromsection="B" to="2" tosecton="E" /> will show sections B and E. But it should show the text _between_ <section start="B"/> and <section end="E"/> - sections B, C, D, E.

In the source code I have found the extension is using {{#lst}} (the documentation says nothing about that), which allow multiple sections transclusion. 

<pages from="1" fromsection="B|C" to="2" tosecton="D|E" />

Above example will do what I want, but it seems hackish - it is neither intuitive nor documented.
Comment 1 Beau 2010-05-05 18:35:16 UTC
Created attachment 7349 [details]
A patch fixing fromsection

I have created a patch, which changes the code of pr_renderPages function a bit. 

The patch should fix an issue with 'fromsection'. Fixing 'tosection' depends on bug #23407.
Comment 2 Beau 2011-08-20 08:49:37 UTC
Created attachment 8945 [details]
Updated version that applies to r93993

I have created an updated patch, that fixes fromsection and tosection behaviour.
Comment 3 John Du Hart 2011-08-23 21:40:54 UTC
Applied in r95338 with minor change ( != should be !== )

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links