Last modified: 2014-04-08 08:56:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24801, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22801 - Search and replace - not always displaying found term
Search and replace - not always displaying found term
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
Macintosh Mac OS X 10.6
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 63665 24493
  Show dependency treegraph
 
Reported: 2010-03-10 23:59 UTC by howief
Modified: 2014-04-08 08:56 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description howief 2010-03-10 23:59:06 UTC
When searching for a word within the editor, the feature usually shows the found term highlighted in the background.    Sometimes, however, the word does not appear highlighted in the background.  In fact, I can't find the location of the found word at all.

1. Edit "San Francisco"
2.  Search for "San Francisco"
3.  Click "find next" a few times
Comment 1 Roan Kattouw 2010-03-11 14:35:50 UTC
Are you sure it's not just behind the dialog?

We should use the line highlight feature here, would be trivial.
Comment 2 Roan Kattouw 2010-03-16 18:53:31 UTC
On second thought, it could also be that the highlighted text is out of view and doesn't get scrolled into view.
Comment 3 Adam Miller 2010-03-16 22:11:38 UTC
Committed some fixes for the search and replace dialog in r63839. Safari still displays an issue with long articles where the selection will not be set properly beyond 15200 characters. IE still displays an issue where the text selected is often not the text that was matched, but rather a few characters before it. All browsers display an issue where matched text inside of template capsules is not shown.
Comment 4 Amir E. Aharoni 2010-05-22 16:15:01 UTC
This dialog doesn't have to be a separate window that hides the text. Google Docs elegantly avoids this problem by displaying the Search and Replace dialog as a toolbar instead. Think also about the search bars in Firefox and Chrome.

In the Hebrew Wikipedia there's a gadget that already does something very similar to the Google Docs' search bar: http://he.wikipedia.org/wiki/MediaWiki:Gadget-EditReplace.js

I think that it only works with the old toolbar and it has a couple of other problems, but the idea should be clear. I can translate the Hebrew strings if you are interested.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links