Last modified: 2010-09-03 22:41:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24602, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22602 - Parser::extractSection() should not use same output type as Parser::preSaveTransform()
Parser::extractSection() should not use same output type as Parser::preSaveTr...
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 93
  Show dependency treegraph
Reported: 2010-02-21 03:24 UTC by Conrad Irwin
Modified: 2010-09-03 22:41 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

implements described change (1.41 KB, patch)
2010-02-21 03:24 UTC, Conrad Irwin

Description Conrad Irwin 2010-02-21 03:24:13 UTC
Created attachment 7155 [details]
implements described change

To fix bug 93 it is necessary to change the behaviour of <includeonly> tags
during preSaveTransform() but not during extractSections(). This could be done either by adding a new preprocessor flag, or by adding a new output type. 

The latter is a better choice, as the current situation where OT_WIKI appears to be used for two things but is only used for one is very counter intuitive. Besides, I can't think of a good name for a flag to add to PPFrame::RECOVER_ORIG to indicate "<ignore>'s the contents of top-level <includeonly> tags instead of <ignore>ing the tags themselves".

OT_WIKI is currently used only for the PST. extractSections() overrides all power that OT_WIKI might have by setting PPFrame::RECOVER_ORIG.
Comment 1 Conrad Irwin 2010-09-03 22:41:42 UTC

Note You need to log in before you can comment on or make changes to this bug.