Wikimedia Bugzilla is closed!

Created attachment 9688 [details]
description patch

this is the patch I created to solve this problem, let me know what you think

I guess it could be better to replace the button with a checkbox, and place the checkbox above the password fields, then hide the password fields if the checkbox is checked...

(In reply to comment #1)
> Created attachment 9688 [details]
> description patch
> 
> this is the patch I created to solve this problem, let me know what you think

This patch inserts 'byemail-explanation' inside 'yourname' in MessagesQqq.php.

Added the need-review keyword to indicate that this patch awaits review from a developer.  Thanks, Emily!

(In reply to comment #4)
> Added the need-review keyword to indicate that this patch awaits review from a
> developer.  Thanks, Emily!

This patch is buggy as I said above. Should I remove "need-review"?

Liangent, I hadn't realized that your "I guess it could be better to..." and "this patch inserts..." comments were critique indicating that the patch has a problem that needs fixing.  I believe this is Emily's first patch to MediaWiki; could you be more specific to help her see how the fix ought to be done instead?

I've replaced "need-review" with the "reviewed" keyword.

(In reply to comment #6)
> Liangent, I hadn't realized that your "I guess it could be better to..." and
> "this patch inserts..." comments were critique indicating that the patch has a
> problem that needs fixing.  I believe this is Emily's first patch to MediaWiki;
> could you be more specific to help her see how the fix ought to be done
> instead?
> 
> I've replaced "need-review" with the "reviewed" keyword.

"This patch is buggy as I said above. Should I remove "need-review"?" is the problem, though I didn't have a complete look at it.

To Emily:

You inserted "'byemail-explanation',       => 'Explains that clicking By E-mail sends a random password to the account that can be changed on login. In [[Special:UserLogin]]'" as a string into the content of 'yourname' message, instead of a new message 'byemail-explanation' with its content 'Explains that clicking By E-mail sends a random password to the account that can be changed on login. In [[Special:UserLogin]]'.

To Sumana:

Actually I believe Emily can spot this little mistake if he/she has a look at the patch again.

thanks for the feedback, I'll work at improving my patch as soon as I can. Unfortonately this is finals week for me at school so I might not be able to get to it right away. Thanks :)
Emily

Emily, have you had time to revise the patch?  I hope you get a chance soon.  Thanks!

@Sumana, sorry for the delay, I'm getting to it now. 
@Liangent do you mean i should just add something like

#By-email explanation
'byemail-explanation'        => 'Clicking By E-mail will send an an auto-generated password to the provided email that can be reset after that new user logs in',


in the file either before of after user login messages?

Is the issue where the message is placed in the file?

(In reply to comment #10)
> @Sumana, sorry for the delay, I'm getting to it now. 
> @Liangent do you mean i should just add something like
> 
> #By-email explanation
> 'byemail-explanation'        => 'Clicking By E-mail will send an an
> auto-generated password to the provided email that can be reset after that new
> user logs in',
> 
> 
> in the file either before of after user login messages?
> 
> Is the issue where the message is placed in the file?

In MessageQqq.php you code looks like:

'yourname'                   => "In user preferences,
'byemail-explanation',       => 'Explains that clicking By E-mail sends a random password to the account that can be changed on login. In [[Special:UserLogin]]'

<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki> is '''NOT''' supported.

{{Identical|Username}}",

But obviously it should be:

'yourname'                   => "In user preferences,

<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki> is '''NOT''' supported.

{{Identical|Username}}",
'byemail-explanation',       => 'Explains that clicking By E-mail sends a random password to the account that can be changed on login. In [[Special:UserLogin]]',

- or -

'byemail-explanation',       => 'Explains that clicking By E-mail sends a random password to the account that can be changed on login. In [[Special:UserLogin]]',
'yourname'                   => "In user preferences,

<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki> is '''NOT''' supported.

{{Identical|Username}}",

Sorry. should be

'yourname'                   => "In user preferences,

<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki> is '''NOT''' supported.

{{Identical|Username}}",
'byemail-explanation'        => 'Explains that clicking By E-mail sends a
random password to the account that can be changed on login. In
[[Special:UserLogin]]',

- or -

'byemail-explanation'        => 'Explains that clicking By E-mail sends a
random password to the account that can be changed on login. In
[[Special:UserLogin]]',
'yourname'                   => "In user preferences,

<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki> is '''NOT''' supported.

{{Identical|Username}}",

(In reply to comment #2)
> I guess it could be better to replace the button with a checkbox, and place
> the
> checkbox above the password fields, then hide the password fields if the
> checkbox is checked...

Done with this solution in I7bf57eef64fea19a8237f997019e0b2bfdf401b3

(In reply to comment #13)
> (In reply to comment #2)
> > I guess it could be better to replace the button with a checkbox, and place
> > the
> > checkbox above the password fields, then hide the password fields if the
> > checkbox is checked...
> 
> Done with this solution in I7bf57eef64fea19a8237f997019e0b2bfdf401b3

Merged by Siebrand on the 24th. Is this better now?

Yes, this is fixed, or rather way more than asked has been done. I've not tested (and the commit says nothing about):
1) wikis with min password length 0;
2) wikis where not all logged in users can create an account.
Moreover I suppose that unregistered users can no longer create accounts for others by email? But I'm not sure this can be called a regression.

(In reply to comment #15)
> Yes, this is fixed, or rather way more than asked has been done. I've not
> tested (and the commit says nothing about):
> 1) wikis with min password length 0;
> 2) wikis where not all logged in users can create an account.
> Moreover I suppose that unregistered users can no longer create accounts for
> others by email? But I'm not sure this can be called a regression.

Createaccountemail was disabled for anons in the past too.