Last modified: 2010-02-16 10:50:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24379, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22379 - Cursor moves to start of inserted text on non-IE browsers
Cursor moves to start of inserted text on non-IE browsers
Status: CLOSED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Roan Kattouw
http://test.wikipedia.org
:
Depends on:
Blocks: 22464
  Show dependency treegraph
 
Reported: 2010-02-04 11:29 UTC by Calcey QA
Modified: 2010-02-16 10:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Calcey QA 2010-02-04 11:29:42 UTC
Reporting against latest version hosted on http://test.wikipedia.org



Steps to reproduce :
1) Start creating a new page in IE
2) Click on New line icon in toolbar 

The cursor is moved to a new line.
In All other browsers <br /> is inserted and cursor is moved to the beginning of the tag.


Expected Outcome :
1) The cursor position after inserting line break shall be consistent across browsers 
2) It would be better if IE behavior (New line is inserted after tag and cursor is at the beginning of new blank link) is available.
Comment 1 nkomura@wikimedia.org 2010-02-09 20:26:24 UTC
This problem is observed with FF3.0 on Ubuntu 9.04 too.
Comment 2 Roan Kattouw 2010-02-09 20:31:24 UTC
(In reply to comment #1)
> This problem is observed with FF3.0 on Ubuntu 9.04 too.

As the title says, this happens on all NON-IE browsers, that includes FF3.
Comment 3 parul 2010-02-09 20:57:16 UTC
Expected outcome (all browsers):  Cursor position after action/formatting (whether with selected text or example text) is at the end of text + formatting.


Exception:  Line break, where the cursor appears at the beginning of a new blank line.  


Possible Exceptions:  In the future, on "inserts" (i.e. toolbar button actions with no selected text), we may want to consider the cursor position to be inside the formatting brackets, where applicable.  

Example:
- (user clicks ref, without anything selected)
- "<ref>Insert footnote text here</ref>" appears in the editor window
- Cursor positioned at the end of "here" before the "</ref>
Comment 4 Roan Kattouw 2010-02-09 22:05:52 UTC
(In reply to comment #3)
> Expected outcome (all browsers):  Cursor position after action/formatting
> (whether with selected text or example text) is at the end of text +
> formatting.
> 
To clarify: this means the cursor position always goes to the end of the inserted text no matter what? We don't wanna select inserted example text?

> Exception:  Line break, where the cursor appears at the beginning of a new
> blank line.  
> 
That's not really an exception, right? The line break is part of the inserted text, after all.

> Possible Exceptions:  In the future, on "inserts" (i.e. toolbar button actions
> with no selected text), we may want to consider the cursor position to be
> inside the formatting brackets, where applicable.  
> 
> Example:
> - (user clicks ref, without anything selected)
> - "<ref>Insert footnote text here</ref>" appears in the editor window
> - Cursor positioned at the end of "here" before the "</ref>
Our previous behavior was to select "Insert footnote here" in this case. But right now you want the cursor to go after </ref> as well, correct?
Comment 5 parul 2010-02-09 22:39:06 UTC
Ack, sorry, you're right.  On "inserts" we should highlight/select example text (i.e. "Insert footnote here")

and the line break is an exception in that it does not appear right after the > of <br/> but rather on the new line.
Comment 6 Roan Kattouw 2010-02-10 10:24:37 UTC
(In reply to comment #5)
> Ack, sorry, you're right.  On "inserts" we should highlight/select example text
> (i.e. "Insert footnote here")
> 
Bleh, that means more work :)

> and the line break is an exception in that it does not appear right after the >
> of <br/> but rather on the new line.

*Technically* it's not an exception, because this button inserts "<br />\n" where \n is a newline, so placing the cursor after the \n (i.e. on the new line) is exactly in line with the other buttons' behavior. Nothing to worry about, though, just means less work for me :)
Comment 7 Roan Kattouw 2010-02-10 14:57:55 UTC
Fixed in r62247.
Comment 8 Calcey QA 2010-02-16 10:50:30 UTC
Tested link: http://prototype.wikimedia.org/deployment-en/
Version : r62529

Verified and close

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links