Last modified: 2010-02-08 06:33:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24226, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22226 - AntiBot GenericFormEncoding prevents editing via API
AntiBot GenericFormEncoding prevents editing via API
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Tim Starling
:
Depends on:
Blocks: 14261
  Show dependency treegraph
 
Reported: 2010-01-22 02:29 UTC by Marcin Cieślak
Modified: 2010-02-08 06:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marcin Cieślak 2010-01-22 02:29:28 UTC
When editing via API (using GET request and application/x-www-form-urlencoded  parameters) GenericFormEncoding prevents editing and writes to the log:

192.2.3.1 AntiBot plugin AntiBot_GenericFormEncoding hit: <no action> [[<no title>]] "{|| some wikitext"

1) it would be useful to have some more information via the API which extension failed (and, if possible, why)
2) Either extensions should assume less about the how the edits are done (not always POST etc.) or use of some other hook should be introduced here to disregard API edits.
Comment 1 Bawolff (Brian Wolff) 2010-01-22 18:42:55 UTC
Umm, you can't edit with the API via GET  whatsoever (regardless of what extensions you have installed), you need to POST. (I assume this is because GET actions are not supposed to have side-affects)
Comment 2 Marcin Cieślak 2010-01-25 11:54:58 UTC
Sorry, I've made a mistake in the bug report. Of course I am using POST request, but the data are sent with Content-Type:  application/x-www-form-urlencoded:

POST /w/api.php
Content-Length: 2248
Accept-Encoding: gzip
User-Agent: PythonWikipediaBot/1.0
Host: www....
Cookie: <somecookies>
Content-Type: application/x-www-form-urlencoded

The AnitBot plugin just requires anything POST'ed to be done with:

Content-Type: multipart/form-data

as specified on the MediaWiki HTML forms.
Comment 3 Roan Kattouw 2010-01-25 11:57:52 UTC
(In reply to comment #2)
> The AnitBot plugin just requires anything POST'ed to be done with:
> 
> Content-Type: multipart/form-data
> 
> as specified on the MediaWiki HTML forms.

That's a stupid limitation in Antibot that should be removed then.
Comment 4 Tim Starling 2010-01-25 12:12:17 UTC
It's just a sample plugin, designed to show how to write them, it's not the real thing. It's obvious that it will have false positives and it says so in the file header. There are two real plugins, which target specific bugs in XRumer. Neither of them are public due to the fear that the XRumer people may google for themselves and fix the bugs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links