Last modified: 2010-01-13 20:23:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23738, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21738 - No recent changes RSS/Atom feeds on Recent Changes page
No recent changes RSS/Atom feeds on Recent Changes page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-01 22:16 UTC by Jools Wills
Modified: 2010-01-13 20:23 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to not exclude recent changes from rss feed (1.25 KB, patch)
2009-12-01 22:16 UTC, Jools Wills
Details

Description Jools Wills 2009-12-01 22:16:14 UTC
Created attachment 6851 [details]
patch to not exclude recent changes from rss feed

Comment in OutputPage.php states

# Recent changes feed should appear on every page (except recentchanges, that would be redundant).

making me think that at some point, recent changes outputted it's own RSS feed. However, I am not sure, but currently there is no RSS feed for recent changes on the recent changes page.

Attached patch removed the check to see if we are on the recent changes page and so adds the recent changes feed to all pages.
Comment 1 Chad H. 2009-12-03 14:52:06 UTC
Cf bug 14500 and r36212 where I removed it.
Comment 2 Roan Kattouw 2009-12-03 15:01:41 UTC
(In reply to comment #1)
> Cf bug 14500 and r36212 where I removed it.
> 

From that bug: there is a <link rel="alternate"> tag pointing to the RC feed on every page. This shows up as e.g. an RSS icon in Firefox's address bar.
Comment 3 Chad H. 2009-12-03 15:05:16 UTC
I suppose it's slightly off-putting to people on older browsers who don't get a UI hint like in Firefox, but still want the URI to the site RSS feed.
Comment 4 Jools Wills 2009-12-03 15:15:55 UTC
i made my patch because I got no UI hint in firefox on the recent changes page. Am i missing something ?
(And i saw nothing in the headers about rss on the recent changes page)
Comment 5 Jools Wills 2009-12-03 15:18:14 UTC
For example

http://en.wikipedia.org/wiki/Special:RecentChanges

where is the feed?
Comment 6 Roan Kattouw 2009-12-03 15:35:30 UTC
(In reply to comment #5)
> For example
> 
> http://en.wikipedia.org/wiki/Special:RecentChanges
> 
> where is the feed?
> 

Ha, apparently it's now missing both. Confirmed this on trunk as well.
Comment 7 Jools Wills 2009-12-03 15:41:06 UTC
yeh as i said in my bug. "but currently there is no RSS feed for recent changes
on the recent changes page." :). my patch fixes this, or i guess we could just revert 36212. 
something must have changed elsewhere ?
Comment 8 Juliano F. Ravasi 2009-12-05 19:41:27 UTC
The problem is not r36212, and also the patch is not the correct one. Special:RecentChanges already have syndication links, it is set in SpecialRecentchanges::webOutput() with a $wgOut->setSyndicated() call.

Note that this bug was introduced in 1.16-svn. If you look deeper, you will find that Special:UnusedCategories and possibly others are also missing syndication links.

The real problem here was introduced in r57119, which made $wgOut->setSyndicated() into a no-op.
Comment 9 Jools Wills 2009-12-06 16:08:00 UTC
aah. I had actually looked at that patch before, and not noticed that. Well spotted. Thanks
Comment 10 Chad H. 2009-12-11 16:38:17 UTC
CCing Andrew since it's his fault :)
Comment 11 Jools Wills 2010-01-12 15:43:35 UTC
Any news on this ?
Comment 12 Alexandre Emsenhuber [IAlex] 2010-01-13 20:23:51 UTC
Fixed in r61021.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links