Last modified: 2009-10-30 03:18:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22913, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20913 - Interface messages: two quick fixes (one missing message, one missing parameter)
Interface messages: two quick fixes (one missing message, one missing parameter)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-30 21:54 UTC by FT2
Modified: 2009-10-30 03:18 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description FT2 2009-09-30 21:54:30 UTC
1/
Messages rev-deleted-text-unhide, rev-deleted-unhide-diff, and rev-suppressed-text-unhide, have a parameter $1 for the link to the item. Message rev-deleted-text-view is missing a $1 parameter.

2/
There are rev-suppress versions of rev-deleted-text-unhide and rev-deleted-text-view, but there isn't a rev-suppress version of rev-deleted-unhide-diff.
Comment 1 Aaron Schulz 2009-09-30 22:08:48 UTC
Why would rev-deleted-text-view need one?
Comment 2 FT2 2009-09-30 22:14:16 UTC
The message for rev-deleted-text-view states:

   This page revision has been '''deleted'''. As an administrator you can view 
   it; there may be details in the [{{fullurl:{{#Special:Log}}/delete|page=
   {{FULLPAGENAMEE}}}} deletion log].

A message that says "you can view this deleted revision" would probably benefit from being able to link to that view; "where do I click" is going to be an obvious question for this message.

(And rev-suppressed-text-view is similar)
Comment 3 FT2 2009-09-30 22:20:29 UTC
Compare:

rev-deleted-text-unhide:  
This page revision has been '''deleted'''... As an administrator you can still [$1 view this revision] if you wish to proceed.

rev-deleted-unhide-diff:
One of the revisions of this diff has been '''deleted'''... As an administrator you can still [$1 view this diff] if you wish to proceed.

rev-deleted-text-view:
This page revision has been '''deleted'''... As an administrator you can view it.
Comment 4 Aaron Schulz 2009-09-30 22:24:08 UTC
I know what they say :)

What would the use be?
Comment 5 Aaron Schulz 2009-09-30 23:15:58 UTC
New diff message in r57172 
Comment 6 FT2 2009-10-01 01:29:47 UTC
Click-through. Administrators and oversighters being told it exists and they can see it, would benefit if the message was directly linked to the thing referenced. It's helpful on other messages. Is there a reason that it wouldn't be helpful here?
Comment 7 Aaron Schulz 2009-10-01 03:17:11 UTC
What do you mean "directly linked to the thing referenced"?

Those links are there for the unhide=1 links. Once you click the link, and then can view the content, the message that shows no longer has them since it would just be a URL to the page the user is already on.
Comment 8 FT2 2009-10-01 11:53:08 UTC
Partly, it's not clear where a given message is used. If this is the message for when a user has already clicked through, and is presently viewing the item, then that would explain it.

On a similar vein, a few interface message matters have come up in the course of using RevDelete this year, as maybe being worth a change to the extension's default messages. Not many, but a few. Shall I add them to the thread here? 
Comment 9 Aaron Schulz 2009-10-30 03:18:12 UTC
(In reply to comment #8)
> Partly, it's not clear where a given message is used. If this is the message
> for when a user has already clicked through, and is presently viewing the item,
> then that would explain it.
> 
> On a similar vein, a few interface message matters have come up in the course
> of using RevDelete this year, as maybe being worth a change to the extension's
> default messages. Not many, but a few. Shall I add them to the thread here? 
> 
Seems unrelated, so one separate bug that covers them all will do.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links