Last modified: 2012-03-19 20:47:04 UTC
Currently, it's a bit confusing for admins without hideuser right: 1. Admin sees EvilUsername 2. Oversight sees EvilUsername and is faster than the admin: He blocks EvilUsername with hideuser 3. Admin goes to Special:Block/EvilUsername. There is a warning, that EvilUser is "Already blocked", but the block log is empty. 4. Admin tries to block user and gets a strange error: "Error: could not submit form" and "<hookaborted>". Expected behavior: Nice error message saying the admin is not allowed to change block settings as the user has been hidden.
Created attachment 6611 [details] attempted patch
Note: Tests on the above patch succeeded on my local install of MediaWiki.
Created attachment 6612 [details] Message Refinement and Rename
Created attachment 6613 [details] Final Fix Unrelated experimenal patch included in the last attachment. Sorry about all the emails.
Created attachment 6618 [details] Sorry again hopefully this really is the last one
Don't forget to add new messages to maintenance/language/messages.inc, please :) Also, try to use tabulator instead of spaces in Special:Blockip.php. It doesn't really look nice atm.
I've tried two different editors to try and fix that problem (Notepad2 and PSPad). What would you recommend to deal with the issue? (Ie that pressing tab just creates spaces.
Created attachment 6624 [details] FIX Hopefully this is the last one. Fixed messages.inc and changed spaces to tabs.
Done in r57375. Minor tweaks (MessagesXX.php uses spaces, not tabulators :))
