Last modified: 2009-09-05 20:09:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22383, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20383 - PHP 5.3.0 throws hooks into an error
PHP 5.3.0 throws hooks into an error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Spam Blacklist (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.yeshiva.org.il/wiki
: newphp
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-25 12:31 UTC by Joe
Modified: 2009-09-05 20:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Joe 2009-08-25 12:31:21 UTC
I wasn't sure, at first this looks like an extension bug, but I think at the core it's really a general MW bug.

My host upgraded PHP from 5.2.5 to 5.3.0 and hooks went crazy. They're giving me this error message:
"Detected bug in an extension! Hook __HOOK FUNCTION NAME__ failed to return a value; should return true to continue hook processing or false to abort."

This happens to many hook extensions, but not all. I can't figure his out, I think it has to do with PHP 5.3.0 compatibility (functions returning NULL instead of false?).

Because it happened to a bunch of hook at once I believe it's a problem with how MW handles the hooks.
Comment 1 Chad H. 2009-08-25 12:33:26 UTC
Not an issue with PHP5.3. Seems as though your extensions are broken and not returning values from their hooks, like they should. Which extensions are showing the error?
Comment 2 Joe 2009-08-25 12:42:20 UTC
(In reply to comment #1)
> Not an issue with PHP5.3. Seems as though your extensions are broken and not
> returning values from their hooks, like they should. Which extensions are
> showing the error?
> 

Official ones: ConfirmEdit, SpamBlackList.
There are a few others I built myself for the project.
Comment 3 Alexandre Emsenhuber [IAlex] 2009-08-25 15:31:42 UTC
For ConfirmEdit this is already fixed, see bug 20371.
Comment 4 Alexandre Emsenhuber [IAlex] 2009-08-25 15:47:25 UTC
Changing Product/Component to MediaWiki extensions/SpamBlackList.
Comment 5 Alexandre Emsenhuber [IAlex] 2009-09-05 20:09:33 UTC
Was fixed in r55449.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links