Last modified: 2009-08-13 20:45:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22087, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20087 - Upload by url is broken
Upload by url is broken
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.16.x
All All
: Normal major (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-06 10:06 UTC by Niklas Laxström
Modified: 2009-08-13 20:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2009-08-06 10:06:16 UTC
At translatewiki.net

$wgEnableJS2system = true;
$wgEnableScriptLoader = true;
$wgAllowCopyUploads = true;

1. Go to Special:Upload
1b. notice how none of the fogg, messages work, showing like <fogg-use_latest_fox><fogg-for_improved_uplods><fogg-please_install>
2. Input a valid url
3. the dialog pops out
4. wait, nothing happens, progress stays at zero
5. click the close icon
6. confirmation dialog with ok and cancel: ok -> nothing happens; cancel: the blue dialog disappears (button actions switched?)
Comment 1 Niklas Laxström 2009-08-06 10:07:10 UTC
Posssibly related from the error log:
[13:02:18] -rakkaus:#mediawiki-i18n- [06-Aug-2009 10:02:19] PHP Notice:  Undefined variable: options in /var/www/w/maintenance/http_session_download.php on line 44
Comment 2 Niklas Laxström 2009-08-06 10:10:46 UTC
Which could indicate possible regression in r54426.
Comment 3 Chad H. 2009-08-06 13:24:25 UTC
FIXED in r54514
Comment 4 Niklas Laxström 2009-08-08 16:08:35 UTC
The warnings are gone, but all the other problems remain.
Comment 5 Brion Vibber 2009-08-10 17:24:22 UTC
Michael, can you check this out? Thanks!
Comment 6 Michael Dale 2009-08-11 17:50:21 UTC
in r54790 copy by url is working for me locally. Is $wgPhpCli set the correct path? 

Is something tricky being done with the language file?
<fogg-use_latest_fox><fogg-for_improved_uplods><fogg-please_install> are in mwEmbed.i18n.php , 

does /w/mwScriptLoader.php?class=mvFirefogg&debug=true  list the language messages?
Comment 7 Michael Dale 2009-08-12 23:49:03 UTC
So there does appear to be a problem with memcahced... 

anyone have any idea why php sessions would work while memcached sessions don't. (this is when running php in a background shell exec passing the session_id as a command line argument) 
Comment 8 Brion Vibber 2009-08-12 23:54:01 UTC
Is translatewiki using memcached or the APC local cache? The latter may not be accessible to the spawned command-line process...
Comment 9 Michael Dale 2009-08-13 00:51:13 UTC
just running $wgSessionsInMemcached = true; locally and its not working either. Any ideas on this one? ... saving state to a db table does not sound fun ... but I don't see much other options yet... is there any tricky way to get the command line version to get access to the memchached session? 
Comment 10 Brion Vibber 2009-08-13 00:54:36 UTC
Well, this is suspicious to me... in Setup.php:

if( !$wgCommandLineMode && ( $wgRequest->checkSessionCookie() || isset( $_COOKIE[$wgCookiePrefix.'Token'] ) ) ) {
	wfIncrStats( 'request_with_session' );
	wfSetupSession();
	$wgSessionStarted = true;
} else {
	wfIncrStats( 'request_without_session' );
	$wgSessionStarted = false;
}

Is the session stuff getting set up properly when we're on the command line?
Comment 11 Michael Dale 2009-08-13 20:45:29 UTC
so it appears to have been a combination of not using wfSetupSession to setup memchahed handler and the use of session_start and session_write_close that where incompatible with memchached non-blocking session handling (but without them php session handling blocks and does not work for background updates)....This was a bit tricky to track-down in the background php process but "should work" with r54965  Tested with both php based handler and memcached handler. 

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links