Last modified: 2009-07-27 00:46:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21934, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19934 - Asynchronous upload from url uses wrong parameters when processing download
Asynchronous upload from url uses wrong parameters when processing download
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-07-26 00:54 UTC by Brad Jorsch
Modified: 2009-07-27 00:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch against r53755 (608 bytes, patch)
2009-07-26 00:54 UTC, Brad Jorsch 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2009-07-26 00:54:13 UTC 
Created attachment 6389 [details]
Patch against r53755

When the upload API is used to make an asynchronous upload from a url, any boolean parameters in the original request will be treated as "true" when the download completes and the upload is processed; in particular, this means asynchronous uploads always act as if ignorewarnings were specified.

The problem is that the API (due to using MediaWiki's WebRequest::getCheck) considers only whether a boolean parameter exists and not what value it might have, and the FauxRequest passed by the download-complete handler likely has all boolean parameters set (to true or false).

One possible fix is to filter out those false boolean parameters before creating the FauxRequest. The attached patch does just that.
Comment 1 Michael Dale 2009-07-27 00:46:34 UTC 
Make sense patch applied in r53792
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links