Last modified: 2014-02-12 23:35:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21605, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19605 - Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced
Hook 'EditFilterMerged' should be called after 'force edit summary' preferenc...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.16.x
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 19680 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-08 21:28 UTC by seth
Modified: 2014-02-12 23:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description seth 2009-07-08 21:28:55 UTC
See e.g. [http://de.wikipedia.org/w/index.php?title=Spezial:Missbrauchsfilter-Logbuch&wpSearchFilter=4]: There is a log entry
:"2009-06-16T21:30:44: 90.136.148.123 [...] triggered filter 4, performing the action "edit" on [[:de:Stempeltechnik]]. Actions taken: none; [...]".
Although rule #4 does not disallow changes (it just logs them), you can't see the change of [[:de:Stempeltechnik]], when you have a look at [[:de:special:contributions/90.136.148.123]]. So what happened there? I gave some more of these examples at [http://en.wikipedia.org/wiki/User_talk:Werdna/Archive_1#63364096679].
Comment 1 Andrew Garrett 2009-07-16 16:41:36 UTC
*** Bug 19680 has been marked as a duplicate of this bug. ***
Comment 2 Prodego 2009-07-16 16:43:55 UTC
When a user is given a warning they must click save a second time in order to save the edit. If they don't do this, the edit is not saved, so nothing will happen. 
Comment 3 Andrew Garrett 2009-07-16 17:07:59 UTC
(batch change)

Minor bugs that nevertheless need looking into
Comment 4 seth 2009-07-16 22:21:14 UTC
(In reply to comment #2)

of course, i know that. the rule i'm talking about does not give a warning and does not disallow edits, it just should log them.
Comment 5 Andrew Garrett 2009-07-31 10:17:31 UTC
For some reason the check for 'force edit summary' is after the hook that AbuseFilter uses.

This option is on by default on de.wikipedia.org — so I'll bet that's what happened.

Unassigning from me, adding some CCs to get wider feedback on whether it should be moved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links