Last modified: 2014-10-07 05:43:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21565, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19565 - Add more variables to AbuseFilter file uploading evaluation
Add more variables to AbuseFilter file uploading evaluation
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal enhancement with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-07 14:37 UTC by Liangent
Modified: 2014-10-07 05:43 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2009-07-07 14:37:57 UTC
as title.
Comment 1 Andrew Garrett 2009-07-16 17:04:33 UTC
(Batch change)

These are low-priority miniprojects that I can mop up at some point when I'm doing general code work as opposed to working on a specific projects.
Comment 2 Andrew Garrett 2009-08-14 12:37:58 UTC
[Batch change]

Removing Dave McCabe from CC, who I somehow managed to add to the CC list of 12 bugs assigned to me.
Comment 3 Rainer Rillke @commons.wikimedia 2011-11-09 13:23:42 UTC
Some checks are possible:
* Title, user, action and SHA1 of file
Reference:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/AbuseFilter/AbuseFilter.hooks.php?view=markup#l280

Especially for Commons it would be desirable if we could check the *content* (wikitext) of the new file for "source= google,..." and other invalid sources to automatically tag them.

Thank you.
Comment 4 Marius Hoch 2013-02-28 01:40:45 UTC
(In reply to comment #3)
> Especially for Commons it would be desirable if we could check the *content*
> (wikitext) of the new file for "source= google,..." and other invalid sources
> to automatically tag them.
> 
> Thank you.
I tried to lay the foundation for this in https://gerrit.wikimedia.org/r/51326 (not yet merged) where I changed the extension to use a hook which provides more data than just the file names... but this still requires some changes to MediaWiki itself and then a follow up to the linked patch.

I'll keep you updated.
Comment 5 Liangent 2013-10-08 08:33:35 UTC
Just found that AbuseFilter already checks file uploads, but there aren't many variables available.

Currently those variables include:

Edit count of user (user_editcount)
Name of user account (user_name)
Groups (including implicit) user is in (user_groups)
Whether or not a user is editing through the mobile interface (user_mobile)
file_articleid = page id of the image page, or "0" for new uploads
file_namespace = "6"
file_text = unprefixed page name of the image page
file_prefixedtext = full page name of the image page
Action (action) = "upload"
SHA1 hash of file contents (file_sha1)
Whether or not the change was made through a tor exit node (tor_exit_node)
Unix timestamp of change (timestamp)

Missing:

upload comment
wikitext of the image page (for new uploads)
Comment 6 Mahitgar 2014-02-27 12:54:38 UTC
Any updates about progress on this bug Please . We prefere this getting fixed. Rgds
Comment 7 Andre Klapper 2014-02-27 13:05:19 UTC
This report has low priority, but if you have a high interest in getting a specific problem fixed, you could provide a patch to speed up the process.
See https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker for more information.
Comment 8 Marius Hoch 2014-02-27 13:14:48 UTC
This is still blocked by changes to how MediaWiki handles uploads (and especially the page creations linked to them)... we need more context from that side (right now AbuseFilter has no way to know about the wikitext used as description).
Comment 9 Stöger Florian D. M. 2014-09-08 20:28:13 UTC
This bug enables bad-faith editors to upload media files with an invalid {{permissionOTRS}} tag without anyone noticing. Therefore, in my opinion, this is not a low priority enhancement.
Comment 10 Andre Klapper 2014-09-08 22:56:52 UTC
[As long as nobody works on this ticket it de-facto will be low priority, no matter what the Priority field will be set to.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links