Last modified: 2012-09-27 01:14:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21194, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19194 - The search function on Wikipedia won't select (Modern + webkit browsers - Safari, Chrome)
The search function on Wikipedia won't select (Modern + webkit browsers - Saf...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
PC Windows XP
: Normal minor (vote)
: ---
Assigned To: River Tarnell
http://en.wikipedia.org/wiki/San_Fran...
:
: 19670 22788 25478 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-14 18:46 UTC by Dilong paradoxus
Modified: 2012-09-27 01:14 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dilong paradoxus 2009-06-14 18:46:28 UTC
When I click on the search bar nothing happens. I have to actually click "search" or "go" and  type in whatever I'm searching there.
Comment 1 Gurch 2009-06-14 18:55:51 UTC
(In reply to comment #0)
> When I click on the search bar nothing happens. I have to actually click
> "search" or "go" and  type in whatever I'm searching there.

It's working fine for me. This sounds like an issue with your web browser.
Comment 2 Robert Stojnic 2009-06-14 21:32:51 UTC
Which browser, which username if logged in?
Comment 3 Dilong paradoxus 2009-06-15 02:59:09 UTC
(In reply to comment #2)

Google chrome, and Utahraptorostrommaysi
Comment 4 fryed-peach 2009-06-25 15:17:55 UTC
This appears to happen in Modern skin with WebKit browsers. BTW, click to the above "Search" label activates the search field.
Comment 5 Brion Vibber 2009-07-19 20:10:35 UTC
Can confirm w/ Safari 4.0.2 and Chrome 3 beta on Mac OS X... looks like it's getting confused when the content area extends vertically below where the search box sits.
Comment 6 Chad H. 2009-08-04 13:43:23 UTC
*** Bug 19670 has been marked as a duplicate of this bug. ***
Comment 7 Derk-Jan Hartman 2009-08-04 14:26:18 UTC
I filed a webkit bugreport.
https://bugs.webkit.org/show_bug.cgi?id=27982
Comment 8 Sumurai8 (NL) 2009-10-04 18:17:10 UTC
It's a chromebug indeed. A simple workaround is changing styles for searchInput:

#searchInput {
  display:inline;
}

I changed it for WikiKids [1] and everything goes fine now [2]

[1] http://wikikids.wiki.kennisnet.nl/MediaWiki:Modern.css?title=MediaWiki:Modern.css&diff=94726&oldid=91184
[2] http://wikikids.wiki.kennisnet.nl/Hoofdpagina?useskin=modern
Comment 9 Lisa Ridley 2010-02-21 22:52:31 UTC
@media screen and (-webkit-min-device-pixel-ratio:0) {
/** safari and chrome specific hack **/
    #searchInput {
        display: inline;
    }
}

The above can be added to modern/main.css and it will fix the issue for Chrome and Safari browsers (and any other browser using WebKit) only.
Comment 10 Derk-Jan Hartman 2010-02-21 23:14:28 UTC
I provided the webkit folks with a reduced case of this problem.
Comment 11 Lisa Ridley 2010-02-21 23:20:01 UTC
Thanks for the link to the bug report at WebKit.  That was filed back in August of last year.  Since we have a work-around is there an objection to applying this to modern/main.css and closing this bug?
Comment 12 Derk-Jan Hartman 2010-02-21 23:22:19 UTC
I consider it to be a hack, but why not. it's not if we can leave all those webkit users out to dry, because the webkit bugzilla isn't used by actual webkit developers....
Comment 13 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-02-21 23:37:12 UTC
(In reply to comment #11)
> Thanks for the link to the bug report at WebKit.  That was filed back in August
> of last year.  Since we have a work-around is there an objection to applying
> this to modern/main.css and closing this bug?

IMO, we should just remove the "display: block" from the #searchInput rule in modern/main.css, unless anyone knows of a good reason for it.  Monobook doesn't use that, and removing it is sufficient to get rid of the problem.
Comment 14 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-02-22 00:00:48 UTC
Lisa committed the workaround in r62794, but thedj reported problems with it, and also with the simple display: block removal I suggested.  I committed r62795, which removes display: block but also sets an explicit width to work around line-wrapping issues.  Marking fixed.
Comment 15 Derk-Jan Hartman 2010-03-10 15:49:47 UTC
*** Bug 22788 has been marked as a duplicate of this bug. ***
Comment 16 Derk-Jan Hartman 2010-03-10 15:50:33 UTC
According to 22788, .portlet { position: relative; } might work as well. This might be a better solution to the problem...
Comment 17 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-03-10 21:42:17 UTC
If there's no problem with the current fix, best to leave well enough alone.  The status quo ante gave us irregular widths for the search box on different browsers, which we may as well avoid anyway, and avoiding that fixes the problem.
Comment 18 Kipmaster 2012-08-09 13:05:48 UTC
*** Bug 25478 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links