Last modified: 2009-11-28 04:55:20 UTC
If createAndPromote is fed a bad password, the account is created anyway. Should roll back the creation if we can't make a valid PW.
Created attachment 6217 [details] Adds password checking; also makes the other messages a little more informative
Fixed in r52336.
As it is, the script is going to report back with "password too short" even if the password was rejected for another reason. (Fixing this will probably require reworking User::setPassword() and User::isValidPassword).
Created attachment 6260 [details] patch to isValidPassword and setPassword Horrible patch to separate too short passwords from invalid passwords. Unfortunately requires a message change.
Fixed in r52494 in trunk. Will merge to branch later.
Copying my notes from Code Review on r52494: Eww... this is a really ugly calling convention. If the function is named 'isSomething', it needs to return a boolean otherwise you're just asking for trouble. An optional outparam for returning a message key would be much less annoying in this context.
This has been fixed for awhile now. User.php was cleaned up, and my original complaint about creating users with bad passwords has also been fixed for quite some time.
