Last modified: 2010-05-15 14:36:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2190, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 190 - Hide your own edits on the watchlist
Hide your own edits on the watchlist
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-08-22 19:23 UTC by M. Creidieki Crouch
Modified: 2010-05-15 14:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
changes needed to SpecialWatchlist.php (2.17 KB, patch)
2005-01-25 15:26 UTC, Richard J. Holton
Details
patch (diff -u) for Language.php (441 bytes, patch)
2005-01-25 15:28 UTC, Richard J. Holton
Details

Description M. Creidieki Crouch 2004-08-22 19:23:12 UTC
It would be really convenient if there were an option to ignore pages that you
were the most recent contributor to when looking at your watchlist.  I imagine
it would be something like the "hide/show minor edits" option on the Recent
Changes page.
Comment 1 Catherine Munro 2004-10-23 11:19:14 UTC
See User:JesseW's bookmarklet for this: http://en.wikipedia.org/wiki/User:JesseW#Bookmarklet
Comment 2 Richard J. Holton 2005-01-25 03:57:19 UTC
This should do the trick. Changes to two files:

To SpecialWatchlist:
18c18
< 	global $wgUser, $wgOut, $wgLang, $wgTitle, $wgMemc, $wgRequest;
---
> 	global $wgUser, $wgOut, $wgLang, $wgTitle, $wgMemc, $wgRequest, $wgContLang;;
40c40,41
< 
---
> 	$hideOwn = $wgRequest->getVal( 'hideOwn' );		
> 	
106a108,111
> 	if (is_null( $hideOwn) ) {
> 		# default is false (don't hide own edits)
> 		$hideOwn = 0;
> 	}
155c160,165
< 
---
> 	if ($hideOwn == 0)
> 		$w = "";
> 	else
> 		$w = "AND (cur_user <> $uid)";
> 		
> 	
165a176
>   $w
183c194,203
< 
---
> 	
> 	$sk = $wgUser->getSkin();
> 	$s = $sk->makeKnownLink(
> 		$wgContLang->specialPage( "Watchlist" ),
> 		($hideOwn==0) ? wfMsg("wlhide") : wfMsg("wlshow"),	
> 	  	"hideOwn=" . $wgLang->formatNum( 1-$hideOwn) );
> 	  	
> 	$note = wfMsg("wlhideshowown", $s);
> 	$wgOut->addHTML( "\n<br />{$note}\n<br />" );
> 	

To: Language.php
1167c1167,1169
< 
---
> 'wlhideshowown'   	=> "$1 my edits.",
> 'wlshow'			=> "Show",
> 'wlhide'			=> "Hide",
Comment 3 Brion Vibber 2005-01-25 05:19:44 UTC
When posting patches on bugzilla, please note a couple things:
* Always attach them as files, not as comments. Comments don't 
format correctly, take up lots of screen space, and are harder to 
keep track of.
* Always post diffs in unified format (diff -u or cvs diff -u). This 
format is easier to read and easier to apply if the file has changed 
since the version you sourced from.
* Resolving a bug as 'WORKSFORME' means that you can't replicate 
the problem, in which case no patch would be necessary.
Comment 4 Richard J. Holton 2005-01-25 15:26:54 UTC
Created attachment 225 [details]
changes needed to SpecialWatchlist.php

Here's a patch file (diff -u) for SpecialWatchlist.php.
Also requires the patch to Language.php (follows).
Comment 5 Richard J. Holton 2005-01-25 15:28:31 UTC
Created attachment 226 [details]
patch (diff -u) for Language.php

The patch for Language.php. Goes with the above patch to SpecialWatchlist.php
Comment 6 JeLuF 2005-03-19 16:09:39 UTC
Implemented in CVS HEAD (aka 1.5)
Comment 7 Ævar Arnfjörð Bjarmason 2005-05-13 14:54:35 UTC
Marking it as FIXED
Comment 8 lɛʁi לערי ריינהארט 2005-06-04 03:42:46 UTC
The benefits for solving this bug are similar to those fixing bug 1417 (Hide own
edits from [[Special:Recentchanges]]) where a patch is available. It would be
nice if both would come together soon.

I realised that the values for &hideOwn and &days are not preserved when
clicking on the related links.
&hideOwn=1&days=7 must be "hacked" manualy into the URL.

Regards Reinhardt

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links