Last modified: 2009-08-31 11:56:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20880, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18880 - make LogEventsList::showLogExtract() more versatile (patch)
make LogEventsList::showLogExtract() more versatile (patch)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.15.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
: 19797 (view as bug list)
Depends on:
Blocks: 16175
  Show dependency tree / graph
 
Reported: 2009-05-22 21:28 UTC by Happy-melon
Modified: 2009-08-31 11:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Against r50880, tweaks LogEventsList::showLogExtract() (1.59 KB, patch)
2009-05-22 21:28 UTC, Happy-melon 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Happy-melon 2009-05-22 21:28:06 UTC 
Created attachment 6145 [details]
Against r50880, tweaks LogEventsList::showLogExtract()

Currently, this function can only be used to write a log extract directly to an OutputPage, invariably $wgOut.  This is sub-optimal.  This patch allows the $out parameter to alternatively be a pointer-to-string which is filled with the content. Fully B/C (AFAIK), return type unchanged. Works fine on my test wiki.
Comment 1 Chad H. 2009-07-18 14:43:44 UTC 
*** Bug 19797 has been marked as a duplicate of this bug. ***
Comment 2 Happy-melon 2009-07-18 16:35:29 UTC 
Oops, sorry for the duplicate, I was just running through a complete diff between my checkout and trunk, and didn't think I'd posted this patch yet. Updated patch against r53416 is attached to bug19797.  Anyone feel like reviewing it? :D
Comment 3 Happy-melon 2009-08-31 11:56:41 UTC 
Applied in r55693.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links