Last modified: 2009-05-11 09:11:09 UTC
Created attachment 6101 [details] against r50336, refactors collection.hooks.php While effective and functional, this code is not as well integrated with MediaWiki's coding conventions or architecture as it could/should be. This patched version is, I hope, more so. I've cleaned up some unused variables and globals, rewritten the hardcoded HTML output to use Xml::tags(), Linker::link() and $wgOut->addScriptFile(), and fixed some double escaping in the tooltips (bug18719, thanks to Niklas Laxström for pointing that one out). I confess I'm not 100% certain I've got the script loads correct, as I'm not entirely sure what script does what. Everything I tested worked as it should :D
Thanks a lot. Reviewed and applied in http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=50472 I've had to add some additional calls to urldecode(). (I guess that's a good thing, because some URLs weren't encoded correctly before, but why doesn't the WebRequest class automatically do the decoding for me? Anyway...)
