Last modified: 2014-02-28 13:52:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20614, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18614 - CodeReview comment formatting overly aggressive with link replacement
CodeReview comment formatting overly aggressive with link replacement
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Special...
:
Depends on:
Blocks: 24279
  Show dependency treegraph
 
Reported: 2009-04-28 18:11 UTC by Brion Vibber
Modified: 2014-02-28 13:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-04-28 18:11:38 UTC
URLs in <pre> sections, and 'bug XXX'/'rXXX' appearing in the middle of something that shouldn't get turned into a link frequently get turned into links. :)

When formatting user comments, we need to make sure we're not interfering with wiki markup.
Comment 1 Dan Jacobson 2009-04-29 18:46:46 UTC
What is driving me bananas is when somebody puts a long string of
unbroken (zzzzz...) (or broken but inside a <pre>) text in a comment.

This in turn takes the whole
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments
<table> along with it.

To reproduce, make a comment with a thousand line string of A's.
Then browse
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments
Note how everybody else's comments now don't fit in the browser, and
you must horizontally scroll back and forth to see each one in entirety.

May be a separate bug...
Comment 2 Roan Kattouw 2009-04-29 19:03:29 UTC
(In reply to comment #1)
> May be a separate bug...
> 
Probably is, yeah, but it's crazy that that table doesn't word-wrap, agreed,
Comment 3 MZMcBride 2009-06-23 04:35:24 UTC
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/51997#c3001 seems related. It's rendering as:

<a href="https://bugzilla.wikimedia.org/show_bug.cgi?id=19359" class="extiw" title="bugzilla:19359">[https://bugzilla.wikimedia.org/show_bug.cgi?id=19359 bug 19359]</a>

Very strange.
Comment 4 Marcin Cieślak 2011-03-29 00:53:37 UTC
Yes, I got this today trying to insert:

[[File:Login-r84930-applied-82155.png]]

in the comment - no image gets inserted, but r84390 is nicely underlined instead :)

Fair trade?
Comment 5 MZMcBride 2011-08-23 20:05:13 UTC
Bumping priority and importance of this. It interrupts development work when people are unable to leave a comment in CodeReview without it being mangled. Currently...

<pre>
http://example.com
</pre>

turns into...

[http://example.com http://example.com]

This is very bad. And this certainly isn't an enhancement request.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links