Last modified: 2014-11-20 09:14:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20526, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18526 - Store user ids in rollback summaries and substitute them run time
Store user ids in rollback summaries and substitute them run time
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.20.x
All All
: Normal enhancement with 4 votes (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks: revdel SWMT
  Show dependency treegraph
 
Reported: 2009-04-19 23:42 UTC by SJ
Modified: 2014-11-20 09:14 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description SJ 2009-04-19 23:42:08 UTC
Active vandals with evil names are often caught and reverted by local admins and rc-watchers before they are hidden.  The resulting reverts, if done in the standard way, include the name in their edit summaries:

https://bugzilla.wikimedia.org/show_bug.cgi?id=18525

After a successful lock and hide, even if resulting edits are deleted from the article history, not only does the name still appear in these histories via the rv's, but it is now harder for local admins to track down all edits by an active spammer or vandal to clean up those ripple-effect edits.

A change to the extension could look for instances of the name to be hidden near the user's edits and offer appropriate action (for instance deleting both the edit and its rv).  This would be easier to script if bug #7566 were resolved.
Comment 1 Mike.lifeguard 2009-04-19 23:47:34 UTC
(In reply to comment #0)
> Active vandals with evil names are often caught and reverted by local admins
> and rc-watchers before they are hidden.  The resulting reverts, if done in the
> standard way, include the name in their edit summaries

If that's a problem then the edit summaries can be hidden.
Comment 2 Mike.lifeguard 2009-04-20 16:11:27 UTC
This also has nothing to do with CentralAuth. Changing component/product accordingly & CCing Aaron.
Comment 3 Mike.lifeguard 2009-04-26 17:10:11 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Active vandals with evil names are often caught and reverted by local admins
> > and rc-watchers before they are hidden.  The resulting reverts, if done in the
> > standard way, include the name in their edit summaries
> 
> If that's a problem then the edit summaries can be hidden.
> 

On the other hand, it may be quite difficult to actually find those edits if, for example, the edit is reverted with undo some edits later. The default edit summary would contain the username, but wouldn't be easily visible by looking at the next diff (or even at the history page, depending on the circumstances).
Comment 4 spacebirdy 2009-05-05 21:48:23 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Active vandals with evil names are often caught and reverted by local admins
> > and rc-watchers before they are hidden.  The resulting reverts, if done in the
> > standard way, include the name in their edit summaries
> 
> If that's a problem then the edit summaries can be hidden.
> 

As said in [1] it would be very handy, of course the summary could be hidden by an oversighter, but the problem is that this happens quite often and that this often includes a lot of reversions, which means lots of edit summaries that would have to be hidden.

You may say that in the edit summary it does no harm, but then what is the purpose of hidename when it does no harm in the summary also on smaller wikis (where such vandalism also occurs), the names and reverts are seen in the rc for a longer time.


Best regards.

[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=17831#c6
Comment 5 Mike.lifeguard 2009-09-05 05:39:29 UTC
hopefully a clearer summary
Comment 6 Alex Z. 2009-10-30 17:52:51 UTC
Note that there isn't an easy way to do this. It would require either fulltext search for edit summaries or possibly a separate links table for links in edit summaries.
Comment 7 Platonides 2011-08-03 18:20:55 UTC
Doesn't seem so hard, but looks more appropiate for a toolserver addon. But I don't think the toolserver would have access to them.
Maybe the edits could be searched by the id, but that would be one for each wiki, which is not friendly..
Comment 8 DerHexer 2012-02-28 21:50:12 UTC
r105432 links the wrong revision.
Comment 9 Marius Hoch 2012-09-13 19:35:25 UTC
With our current database scheme, this isn't doable and introducing either fulltext search to edit summaries or list links in a page_links like manner to resolve this is totally overexaggerated. So WONTFIX.
Comment 10 MZMcBride 2012-09-14 00:08:47 UTC
I'm not sure why local wiki administrators can't simply remove the username from the reversion summaries if it bothers them. It's a matter of tweaking a few MediaWiki messages and maybe a few user scripts.

The easiest way to clean up a mess is to not make one in the first place. If wikis are concerned about these offensive usernames in reversion summaries, stop including them. :-)
Comment 11 Kunal Mehta (Legoktm) 2014-08-08 16:09:00 UTC
Re-opening, there's a valid bug here, even if the solution is hard.
Comment 12 Marius Hoch 2014-08-08 16:12:41 UTC
Solution would be to only store user ids in rollback summaries and then only substitute them with user names on run time. That way suppressions etc. could be taken into a account.
Comment 13 MF-Warburg 2014-08-08 16:20:31 UTC
Or change {{int:revertpage}}
Comment 14 Marius Hoch 2014-08-08 16:22:02 UTC
(In reply to MF-Warburg from comment #13)
> Or change {{int:revertpage}}

That's implied by this.
Comment 15 Gerrit Notification Bot 2014-08-13 23:36:01 UTC
Change 153979 had a related patch set uploaded by Legoktm:
[WIP] Store user id in revert messages

https://gerrit.wikimedia.org/r/153979

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links