Last modified: 2013-04-22 16:15:28 UTC
Message Abusefilter-diff-version needs date/time separated,
since internationalization would otherwise be impossible.
Sentences of some languages have to have grammatical stuff put
between date, and time, or between time, and date, respectively,
as to form correct sentences or fragments.
Since users have grammatical genders now, the unaltered user name
must be passed as a parameter to the message, in order to be used
in the GENDER construct for languages having gender aware grammars.
Added GENDER support in r52735.
(In reply to comment #2)
> Added GENDER support in r52735.
I don't think replaceafter and parser functions work together.
(In reply to comment #3)
> (In reply to comment #2)
> > Added GENDER support in r52735.
> I don't think replaceafter and parser functions work together.
Minor bugs that nevertheless need looking into
If I understand correctly, the raw username is already passed in the current version:
$headings .= Xml::tags( 'th', null,
$this->msg( 'abusefilter-diff-version' )
->rawParams( $oldLink, $oldUserLink )
->params( $newVersion['meta']['modified_by_text'], )
And rawParams and params solve the problem from Comment 3.
Param $3 is not used in the source language or documented as far as I can see.
Polished the GENDER support in https://gerrit.wikimedia.org/r/#/c/29776/ .
(In reply to comment #8)
> Polished the GENDER support in https://gerrit.wikimedia.org/r/#/c/29776/ .