Last modified: 2012-09-27 01:10:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19710, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17710 - Full set of "jump to" accessibility links
Full set of "jump to" accessibility links
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.16.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://transgender-taiwan.org/index.p...
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-27 23:11 UTC by Dan Jacobson
Modified: 2012-09-27 01:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
we jump to "Views" so say so (1.08 KB, patch)
2009-06-03 04:45 UTC, Dan Jacobson
Details
adds the word "all" to jumptonavigation, but only for three languages (2.18 KB, patch)
2009-07-08 11:22 UTC, Dan Jacobson
Details
makes Jumptonavigation say "sidebar", but only for one language so far (746 bytes, patch)
2009-07-08 11:24 UTC, Dan Jacobson
Details
in vector skin, jumpto search jumps nowhere, and jumpto navigation doesn't jump there (56.92 KB, image/png)
2009-07-20 21:46 UTC, Dan Jacobson
Details

Description Dan Jacobson 2009-02-27 23:11:14 UTC
The above URL is linked to the word "navigation".
However, it no longer jumps to the "Navigation" section, but instead to the "Views" section.
One must manually scroll down to get to the "Navigation" section.
Note you might need to turn off CSS or use lynx etc. to see what I am talking about at all.
Affects all languages.

You could change the names, or better, just really jump to Navigation.
Comment 1 Dan Jacobson 2009-06-03 04:45:40 UTC
Created attachment 6189 [details]
we jump to "Views" so say so

OK, here is a patch. Don't you agree the link makes 200% more sense now?

(Remember you must in e.g., Firefox, use "View>Page Style>No Style" to
see what I'm talking about.)

The only problem is now that we are looking at
>"Jump to: Views, search"
one capitalized, the other lowercase.

The solution is to go ahead and (please you go ahead and also) on that
same line of source code, change msg('jumptosearch') to msg('search').

And remember to make those changes for the other skins too.

I can do the above easily if you would like, however the following I
would prefer somebody else to do:

You might as well retire the two strings jumptonavigation, and
jumptosearch, as they will no longer be used.

Discussion: There in fact is a place called "Navigation". It's there in
the sidebar code. And even though it has a nice name, it is not where
you currently are jumping to, (nor should it be, as you currently jump
to a better place).

The above patch corrects the confusion by using the same label, at
source and destination.
Comment 2 Dan Jacobson 2009-07-06 02:18:23 UTC
And for Vector skin, on
http://transgender-taiwan.org/index.php?uselang=en&useskin=vector
the link labeled "navigation",
http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#head
jumps to "Personal tools", i.e., the same place
http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#personal
jumps to, and not the place with the word "Navigation", i.e.,
http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#p-navigation

Can somebody please in their Firefox do View>Page Style>No style and
confirm I'm not nuts?
Comment 3 Roan Kattouw 2009-07-07 17:41:03 UTC
(In reply to comment #2)
> And for Vector skin, on
> http://transgender-taiwan.org/index.php?uselang=en&useskin=vector
> the link labeled "navigation",
> http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#head
> jumps to "Personal tools", i.e., the same place
> http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#personal
> jumps to, and not the place with the word "Navigation", i.e.,
> http://transgender-taiwan.org/index.php?uselang=en&useskin=vector#p-navigation
> 
> Can somebody please in their Firefox do View>Page Style>No style and
> confirm I'm not nuts?
> 

Confirmed it jumps there, but not sure it's wrong. Monobook doesn't jump to navigation either, but jumps to "Views". Also, the order is different between the skins. I understand the navigation link to jump to the first of the bulleted lists of links, so in that sense it works. Closing as WORKSFORME unless there's a compelling argument to change stuff; jumping to the first of the navigation lists for convenience rather than jumping to the middle of them for correctness sounds better to me.
Comment 4 Dan Jacobson 2009-07-08 01:14:53 UTC
This is even worse than bug 18403.
Yes, if it just said 'jump to "first of navigation links"' it would make more sense... there has to be a better way.
Non text browser users just don't understand how (non)funny this looks.
Comment 5 Roan Kattouw 2009-07-08 03:13:10 UTC
(In reply to comment #4)
> This is even worse than bug 18403.
> Yes, if it just said 'jump to "first of navigation links"' it would make more
> sense... there has to be a better way.
> Non text browser users just don't understand how (non)funny this looks.
> 

I agree that the link doesn't do what it says, but I do think that the place it points to right now is the right place for it to point to. Maybe the caption should be changed to be more correct.
Comment 6 Dan Jacobson 2009-07-08 11:17:27 UTC
>jumping to the first of the navigation lists for convenience rather
>than jumping to the middle of them for correctness sounds better to me.
Me too.

> Maybe the caption should be changed to be more correct.
"♫ Here I come to save the day ♫ ☺"... (in my usual half-ass ♪ way ☹):
I'll add two different solution patch ideas to chose from...

For both solutions I'm worried that the translation won't percolate
down, so maybe retire 'jumptonavigation' from everywhere in the code,
and use a different variable that would start fresh...
Comment 7 Dan Jacobson 2009-07-08 11:22:49 UTC
Created attachment 6308 [details]
adds the word "all" to jumptonavigation, but only for three languages

Solution 1: just like bug 18403 (so I'll slide Brion into the Cc list),
add the word "all" to distinguish. (plural navigationS sounds funny.)
Comment 8 Dan Jacobson 2009-07-08 11:24:20 UTC
Created attachment 6309 [details]
makes Jumptonavigation say "sidebar", but only for one language so far

Solution 2: say in fact "sidebar", that way even text browser users
with nothing on the side would even know where the "sidebar" people talk about is.
Comment 9 Dan Jacobson 2009-07-08 11:28:59 UTC
Or say "navigation group", or say "controls", you name it... anything other than plain "navigation" which is already used... (unless you want to change that instead...urggg.)
Comment 10 Dan Jacobson 2009-07-20 21:46:19 UTC
Created attachment 6374 [details]
in vector skin, jumpto search jumps nowhere, and jumpto navigation doesn't jump there
Comment 11 Dan Jacobson 2009-07-20 22:00:20 UTC
Let me approach this bug from a different point of view, the vector
skin. See attachment 6374 [details], made when browsing
http://transgender-taiwan.org/index.php?uselang=en&useskin=vector

The vector skin's "search" jumpto link jumps nowhere.

Also the "navigation" jumpto link does not jump to the place that says
"navigation", but instead to a better place, which is good, but confusing, as elaborated above.

Be sure to use View > Page Style > No Style in Firefox to know what I'm talking about.
Comment 12 Trevor Parscal 2009-07-21 17:59:55 UTC
Solved in r53611. This was actually a regression, broken when #search was changed to #p-search in r52816.
Comment 13 Dan Jacobson 2009-07-21 18:35:02 UTC
OK, thank you for fixing #p-search.
I had one of those "Ah-ha! moments" (what's the opposite of an "Ah-ha!
moment"?), and hope somebody will consider my idea to straighten out
the remaining "Jump to" accessibility links, first for the vector
skin, and if proves feasible, for the remaining skins.

Current situation:
Jump to: navigation, search
Views
Personal tools
Navigation
Search
Toolbox
and "naviagtion" jumps to Views, not Navigation.

Jidanni July 2009 proposed situation:
Jump to: Views, Personal tools, Navigation, Search, Toolbox
Views
Personal tools
Navigation
Search
Toolbox
and each jumps to it's rightly named destination. And of course we
know that not each of the destinations will always be generated,
(e.g., there are more in fact that you don't see here)
therefore each Jump to item should only be appended if its
corresponding destination will exist!
A total win-win situation!
(Don't worry, we accessibility concerned users will not complain that
the page is now TOO accessible. Just make sure the Jump to links are
in the same order as they will appear below. If you think my idea is a great one and need a patch, just ask.)

Comment 14 Dan Jacobson 2009-07-21 18:39:43 UTC
Comment on attachment 6374 [details]
in vector skin, jumpto search jumps nowhere, and jumpto navigation doesn't jump there

Purple line fixed.
Red line problem could be solved by having links for each destination, as mentioned in comment #13.
Comment 15 Trevor Parscal 2009-07-21 19:06:53 UTC
The navigation link goes to #head, which jumps to the beginning of the links which are normally in the head. Although on Wikipedia the first sidebar is also called "navigation", this is not true for all wikis, since this is a locally configurable thing. Thus, the current behavior is the correct behavior, and this bug is closed.
Comment 16 Dan Jacobson 2009-07-21 19:12:58 UTC
(In reply to comment #15)
I never ever even tested Wikipedia. It is true for all wikis unless the administrator hacks his wiki! That's how Mediawiki ships out of the box.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links