Last modified: 2011-01-25 00:42:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19159, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17159 - Diffs should assume redirect=no
Diffs should assume redirect=no
Status: RESOLVED DUPLICATE of bug 22496
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
: 4973 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-26 11:20 UTC by Gurch
Modified: 2011-01-25 00:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2009-01-26 11:20:39 UTC
This URL had me confused for a while:

http://en.wikipedia.org/w/index.php?title=Khety_II&diff=266098037

* Title parameter is "Khety II"
* Title shown on the page is "Khety II"
* HTML title attribute is "Khety II"
* Both revisions in the diff are from the page "Khety II"
* Both "Revision as of" titles link to old versions of "Khety II"
* Both "edit" links next to the revision titles link to old versions of "Khety II"

BUT

* "Next edit" and "Previous edit" links put "Ninth dynasty of Egypt" in the title (though lead to other edits to Khety II)
* Article, discussion, edit, history, move and watch tabs all link to "Ninth dynasty of Egypt"
* Diff says "8 intermediate revisions not shown" when there are no intermediate revisions

It is clearly broken behaviour for "article", "discussion", etc. tabs to link to a page other than that shown in the page title, and also broken behaviour for them to link to a page that is not the page either of the revisions being compared belongs to.

The unexpected intrusion of links to [[Ninth dynasty of Egypt]] here is presumably because that's where the current version of [[Khety II]] redirects to. Compare an identical URL with "redirect=no" appended:

http://en.wikipedia.org/w/index.php?title=Khety_II&diff=266098037&redirect=no

Now everything links to the right place.

So, diffs should behave as though "redirect=no" was supplied even if it wasn't.
Comment 1 Gurch 2009-01-27 12:53:04 UTC
Actually, no harm in assuming it for all diffs, which would be simpler.
Comment 2 Brion Vibber 2009-07-19 23:13:23 UTC
*** Bug 4973 has been marked as a duplicate of this bug. ***
Comment 3 Alexandre Emsenhuber [IAlex] 2010-05-29 18:19:47 UTC

*** This bug has been marked as a duplicate of bug 22496 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links