Last modified: 2009-01-27 08:48:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19157, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17157 - Pristine revisions should override quality revisions
Pristine revisions should override quality revisions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-25 21:59 UTC by Alex Z.
Modified: 2009-01-27 08:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Z. 2009-01-25 21:59:39 UTC
When a page has both pristine revisions and quality revisions, and quality versions are set to have precedence over sighted revisions, pristine versions should have precedence over quality versions.

Alternately, 
If using pristine versions, there should be an option on Special:Stabilization to give pristine versions precedence over quality/sighted versions.
Comment 1 Aaron Schulz 2009-01-25 23:45:24 UTC
"pristine" version were mainly meant to just be markers for FA level revisions. It isn't really practical to have them override anything, and thus the code to set them to do so (per page) is commented out.
Comment 2 Alex Z. 2009-01-26 05:48:44 UTC
Well, basically what I'd like to do is have a system so that the highest quality revision will have precedence, (there's only 3 levels so sighted/quality/pristine would work for this) but FlaggedRevs currently makes no distinction (as far as precedence is concerned) between anything other than quality/not-quality.
Comment 3 Aaron Schulz 2009-01-26 20:48:14 UTC
Done in r46280, r46283
Comment 4 Alex Z. 2009-01-26 23:07:54 UTC
Something seems to be ... backwards. The relevant bit of the config I have is:

$wgFlaggedRevTags = array( 'protection' => 2 );
$wgFlaggedRevValues = 3;
$wgFlaggedRevPristine = 3;
$wgFlaggedRevsPrecedence = 2;

However, when setting a page to show "The latest pristine revision; if not present, then the latest quality or sighted one," quality revisions override pristine revisions. An older quality revision is shown as the stable version even if the current rev is pristine. I checked the database, fr_quality is being set correctly.
Comment 5 Aaron Schulz 2009-01-27 04:04:37 UTC
Fixed in r46319
Comment 6 Happy-melon 2009-01-27 08:48:03 UTC
This is clearly asking for an evolution of the stablesettings system towards a more general "where on the flag scale do you want the boundary between immediately-visible edits and 'draft' edits to be set?" sliding scale.  It would only be a UI change, and a fairly intuitive one at that, to combine the two radiobox options we currently present into one scale:

"""Select the minimum quality of revision that will be immediately visible.  Edits flagged as this quality or higher will be immediately visible to all users; edits of lower quality will require review to be included

0 featured
0 verified
0 sighted
X unsighted

"""

Good idea? Is it worth opening a bug for this?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links