Last modified: 2014-03-19 19:35:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 17029 - Session failure warning message ('sessionfailure') gives bad advice
Session failure warning message ('sessionfailure') gives bad advice
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: messages
  Show dependency treegraph
 
Reported: 2009-01-14 22:36 UTC by Brion Vibber
Modified: 2014-03-19 19:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-01-14 22:36:47 UTC
The default sessionfailure message reads:

'There seems to be a problem with your login session;
this action has been canceled as a precaution against session hijacking.
Please hit "back" and reload the page you came from, then try again.',

This is not a super great suggestion -- hitting 'back' and/or reloading will in some browsers lose your form state, so you've now lost all your work and have to start over.

In most cases, the correct fix is actually to more like *hit the submit button again*, since the rest of your form state will be preserved... possibly going to login and preview beforehand, though.

Generally this kind of sucks.
Comment 1 Nemo 2012-07-25 09:06:52 UTC
(In reply to comment #0)
> This is not a super great suggestion -- hitting 'back' and/or reloading will in
> some browsers lose your form state, so you've now lost all your work and have
> to start over.

Are browsers still so stupid? Firefox has always handled this quite well, I think Chromium does too, of course I don't know about IE.
Comment 2 Nemo 2013-11-19 12:36:36 UTC
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
Comment 3 Gerrit Notification Bot 2013-11-19 21:29:42 UTC
Change 96370 had a related patch set uploaded by Mayankmadan:
Replacing please hit back and reload with click the submit button

https://gerrit.wikimedia.org/r/96370
Comment 4 Gerrit Notification Bot 2013-11-20 14:47:06 UTC
Change 96370 abandoned by Bartosz Dziewoński:
Replacing please hit back and reload with click the submit button

Reason:
Since you submitted another patch for your GCI task instead, I am assuming you do not want to follow up with this.

Closing the changeset here; if you ever want to return to it, just click "Restore".

https://gerrit.wikimedia.org/r/96370
Comment 5 Bartosz Dziewoński 2013-11-26 22:24:45 UTC
Per Siebrand's code review on the above patch, not so easy.

Patch amounted to:
- Go back to the previous page, reload that page and then try again.
+ Click the submit button again.

Review was:
> Hmm. This message is a bit awkward. It's for example also used in
> dieUsage() in ApiMain and ApiPersona:
> $this->dieUsageMsg( 'sessionfailure' );

> The suggestion that is being added here is most probably not correct
> in that case. Not sure what the correct solution is; maybe splitting
> up in multiple UI strings (one for non-interactive interaction (pun
> intended) and one for interactive use cases) (?).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links