Last modified: 2012-08-01 18:38:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17009 - Remove .hiddenStructure from CSS
Remove .hiddenStructure from CSS
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal minor with 5 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: accessibility
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2009-01-13 22:58 UTC by Happy-melon
Modified: 2012-08-01 18:38 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Happy-melon 2009-01-13 22:58:23 UTC
It's been deprecated for over three years now, yet we're still forced to manually override this to stop people using the damn thing.  If people want to continue using a terrifying hack that royally screws over people with older browsers (vide Brion http://en.wikipedia.org/wiki/Wikipedia_talk:Avoid_using_meta-templates?diff=36124214), they can add the definition themselves, it's not exactly difficult.  But given how many other friendlier ways there are of hiding content, it's crazy to leave this in there just because it's been there since forever.  

trunk/phase3/skins/monobook/main.css:
@@ 487:
- .hiddenStructure {
- 	display: none;
- }
Comment 1 Chad H. 2009-01-15 20:46:28 UTC
Using it for its original purpose (in meta templates?) was bad. Leaving it as a general CSS class declaration for hiding things shouldn't hurt anyone...?
Comment 2 Melancholie 2009-01-16 19:52:35 UTC
Please note that this class is being used on wikis here and there.
Removal will suddenly unhide stuff on wikis out there making use of this.
Comment 3 Lejonel 2009-10-10 20:24:35 UTC
If it is removed it should also be removed in css for other skins (modern, vector, and maybe other).

If it is not removed, maybe it should be moved to a skin independent css file. Currently the class is missing for old skins like Standard and CologneBlue.
Comment 4 Bryan Baron 2009-10-27 02:34:26 UTC
If any wiki still wants to use this class, the sysops can put the class back in the local common.css.
Comment 5 Rodan BURY 2010-10-23 14:46:33 UTC
(In reply to comment #4)
> If any wiki still wants to use this class, the sysops can put the class back in
> the local common.css.

Yes. The biggest wikis already wiped out most of the hiddenstructure usages anyway.

The thing is, since the class still exists editors keep using it. And it's a pain to have to check the templates on a regular basis to ensure nobody tried using it again. And really often, we find yet nother buch of templates that we have to rewrite completely.

So please, let's remove it once and for all.
Comment 6 Happy-melon 2011-03-30 16:44:27 UTC
Removed in r85017.
Comment 7 Helder 2012-08-01 18:38:57 UTC
For the record: it is really difficult to get rid of it. We still have at least 400 pages on Portuguese Wikipedia using the old class...

https://pt.wikipedia.org/w/index.php?oldid=31420316&uselang=en

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links