Last modified: 2008-12-27 20:36:42 UTC
I used the latest SVN build and noticed this oddity in the user rights log entry: 14:22, 28 November 2008 WikiSysop (Talk | contribs) changed group membership for User:TestUser from Sysops to Sysops, and Bureaucrats (temporary) Is there meant to be a comma when adding another usergroup?? It used to be: 14:22, 27 November 2008 WikiSysop (Talk | contribs) changed group membership for User:Testing from Sysops to Sysops and Bureaucrats (test) Anyone know why this has happened on the trunk version?? It doesn't seem to appear on any Wikimedia sites.
Created attachment 5554 [details] special case for two messages in log Removed the comma from MediaWiki:and and moved the adding of a comma into Language.php
Modified patch applied with r45101: "... moved the adding of a comma into Language.php" was unneeded.
To be honest, the behavior of the logs now is silly. It made much more sense to have for example: 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership for User:Testing from sysop to sysop, bureaucrat (test) instead of 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership for User:Testing from Sysops to Sysops and Bureaucrats (test)
(In reply to comment #3) > To be honest, the behavior of the logs now is silly. It made much more sense to > have for example: > > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership > for User:Testing from sysop to sysop, bureaucrat (test) > > instead of > > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership > for User:Testing from Sysops to Sysops and Bureaucrats (test) > I don't see why. Lists of this sort in English are separated by a comma, with 'and' between the last two items (comma there optional depending on who you ask). "Sysops and Bureaucrats" is more correct and "Sysops, Bureaucrats" isn't (though the caps and plural is wrong wrong wrong) - perhaps that's not true in other languages.
(In reply to comment #4) > (In reply to comment #3) > > To be honest, the behavior of the logs now is silly. It made much more sense to > > have for example: > > > > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership > > for User:Testing from sysop to sysop, bureaucrat (test) > > > > instead of > > > > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership > > for User:Testing from Sysops to Sysops and Bureaucrats (test) > > > > I don't see why. Lists of this sort in English are separated by a comma, with > 'and' between the last two items (comma there optional depending on who you > ask). "Sysops and Bureaucrats" is more correct and "Sysops, Bureaucrats" isn't > (though the caps and plural is wrong wrong wrong) - perhaps that's not true in > other languages. > At the very least, the plurality and capitalization can be removed. Though this isn't really considered a list, it's a log entry. And I still stand by my opposition for the current format with the usage of "and".