Last modified: 2014-06-07 21:30:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18111, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16111 - MediaWiki:Cascadeprotected and MediaWiki:Cascadedprotectedwarning should take the same parameters
MediaWiki:Cascadeprotected and MediaWiki:Cascadedprotectedwarning should take...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Amir E. Aharoni
: easy, i18n
Depends on:
Blocks: 18521
  Show dependency treegraph
Reported: 2008-10-25 16:42 UTC by Happy-melon
Modified: 2014-06-07 21:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Happy-melon 2008-10-25 16:42:32 UTC
These templates are mutually exclusive: [[MediaWiki:Cascadeprotectedwarning]] is displayed when the user does not have the ability to edit through the protection, [[MediaWiki:Cascadeprotectedwarning]] is displayed when they can edit.  [[MediaWiki:Cascadeprotected]] takes two parameters, $1 being the number of locking pages, and $2 being a list of links to those pages.  [[MediaWiki:Cascadeprotectedwarning]], on the other hand, only takes the first parameter (number of locking pages), and hardcodes the display of the list of pages underneath.  This means that it is, for instance, impossible to apply ids or styles to the whole section.  [[MediaWiki:Cascadeprotectedwarning]] should be modified to define the display of both the message and the list.
Comment 1 Siebrand Mazeland 2011-09-14 13:14:44 UTC
Volunteered by Amir during bug triage.
Comment 2 Amir E. Aharoni 2011-09-18 22:25:33 UTC
I read the relevant code and i think that i have several options for fixing this, but i wonder:

1. Is there a reason to keep the two messages? Maybe they can be merged? They are almost identical in every regard.

2. Is there a reason to keep the pages list as a parameter?
Comment 3 Andre Klapper 2014-02-21 00:51:32 UTC
Happy-melon: Can you answer comment 2, please?
Comment 4 Andre Klapper 2014-03-20 11:51:04 UTC
Happy-melon: Can you answer comment 2, please?
Comment 5 Jackmcbarn 2014-06-07 21:30:45 UTC
1. Although the messages appear similar in the default installations, many wikis have heavily customized each of them in different ways. I don't think it would be beneficial to merge the messages.
2. Many wikis display the list within custom code, which wouldn't be possible without it being a parameter.

Note You need to log in before you can comment on or make changes to this bug.