Last modified: 2009-01-12 16:47:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17980, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15980 - {{REVISIONTIMESTAMP}} does not function as documented
{{REVISIONTIMESTAMP}} does not function as documented
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.14.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-14 12:02 UTC by Brad Jorsch
Modified: 2009-01-12 16:47 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2008-10-14 12:02:43 UTC
Regarding r42075.

The comments in the code indicate that {{REVISIONTIMESTAMP}} is supposed to output the timestamp adjusted for the server-local timezone. However, the actual page output is adjusted for the timezone of the user who last triggered parsing of the page.

I'm not sure if the underlying bug is in getRevisionTimestamp() [includes/parser/Parser.php line 4646] or in userAdjust() [languages/Language.php line 466]. REVISIONTIMESTAMP expects that passing '' to userAdjust() for the $tz parameter will use the server-local timezone. However the "if (!$tz)" check in userAdjust() at line 469 overrides $tz with the user timezone if $tz is ''. I don't know whether passing '' to userAdjust() to get the server-local timezone is the intended behavior (in which case that check should be "if ($tz === false)") or whether getRevisionTimestamp() is wrong in thinking that works.
Comment 1 Brad Jorsch 2009-01-12 16:47:12 UTC
This was taken care of in r44915, by changing userAdjust().

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links