Last modified: 2011-04-14 15:13:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17959, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 15959 - Tidy replaces tabs with spaces
Tidy replaces tabs with spaces
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.14.x
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test.wikipedia.org/wiki/Tabs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-10-13 00:25 UTC by Danny B.
Modified: 2011-04-14 15:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Danny B. 2008-10-13 00:25:38 UTC 
Tidy replaces tabs with spaces and per documentation http://tidy.sourceforge.net/docs/quickref.html#tab-size it never outputs tabs.

However it passes through 	 entity.

Thus all tabs in wikitext source between <pre></pre> and <source></source> should be replaced by the entity before passing to Tidy.
Comment 1 Brion Vibber 2008-10-13 00:28:02 UTC 
We could do str_replace from literal tab to &#9; and back in the wrappers around tidy calls. This would transform anything that was already using the numeric entity to a literal tab, but I think our Sanitizer would already do this, and it should be harmless.
Comment 2 Fran Rogers 2008-10-20 06:46:39 UTC 
Fixed in r42257.
Comment 3 P.Copp 2010-11-29 00:30:58 UTC 
r42257 has been reverted. Reopening.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-11-29 00:32:36 UTC 
Specifically because the fix caused other, more severe bugs.  The real solution here is to get rid of Tidy.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links