Last modified: 2013-04-06 14:34:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17929, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15929 - CologneBlue.php may need code modernisation
CologneBlue.php may need code modernisation
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.14.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: 46949
  Show dependency treegraph
 
Reported: 2008-10-10 15:26 UTC by NSK Nikolaos S. Karastathis
Modified: 2013-04-06 14:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch reusing code from nostalgia (2.71 KB, patch)
2010-02-06 10:42 UTC, Karun
Details

Description NSK Nikolaos S. Karastathis 2008-10-10 15:26:18 UTC
In bug # 15868 there is a comment about code imperfections which, although about a patch, in fact may also apply in CologneBlue.php, therefore the skin code may be in need of code modernisation.
Comment 1 Karun 2010-02-06 10:42:13 UTC
Created attachment 7082 [details]
Patch reusing code from nostalgia

Ive modernised it based on the content of bug # 15868, and reused the code from r43182 from Nostalgia.
Comment 2 Marcin Cieślak 2011-03-13 23:41:03 UTC
What this patch does is to replace to the top links:

* Main Page | About | Help | FAQ | Special pages | Log out (or Log in)

with

* Main Page | Recent changes | Edit this page | Userpage | User talk |
Watchlist | My contributions | Preferences | Logout

All of the above links are already available from the left-hand side
sidebar, we don't need to copy Monobook here.

Second thing this patch does is to replace collecting of menu items
in an array and then joining them with a separator with plain string
concatenation. Personally I prefer the functional style of the original
code.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links