Last modified: 2008-10-10 21:46:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17928, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 15928 - Nostalgia has a trailing | in link lines which perhaps should not be there
Nostalgia has a trailing | in link lines which perhaps should not be there
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.14.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-10-10 15:04 UTC by NSK Nikolaos S. Karastathis
Modified: 2008-10-10 21:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description NSK Nikolaos S. Karastathis 2008-10-10 15:04:18 UTC 
The Nostalgia skin has a trailing "|" character at the end of its top links and bottom links lines.  Is this necessary?  I consider it a bug.  At least another one person considers it a bug too (bug number #15868).

I suggest its removal.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-10-10 17:48:17 UTC 
After inspecting the source code, I found that the separator was meant to separate the special pages dropdown, which was meant to display inline, but didn't because of a bug.  I made the special page dropdown inline as was intended, which makes the separator meaningful and also might save screen real estate.

Fixed in r41940.
Comment 2 NSK Nikolaos S. Karastathis 2008-10-10 21:46:37 UTC 
Great fix, thanks for committing!  The fix is very useful as it helps to save screen real estate.  I immediatelly put your fix to good use as I grabbed it from the svn for my production wikis (adventrurously running on HEAD).

Would it be possible that a similar bug may exist with the search box? (which I suggested being moved up for a diferent reason, see bug # 15902).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links