Last modified: 2008-10-09 11:46:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17730, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 15730 - #iferror should catch more errors
#iferror should catch more errors
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ParserFunctions (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-09-26 04:42 UTC by René Kijewski
Modified: 2008-10-09 11:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description René Kijewski 2008-09-26 04:42:13 UTC 
Currently #iferror catches errors if and only if it is the only class applied to a (strong|span|p|div). I'd propose to change ParserFunctions.php's line 136 to test the string against

<(?:strong|span|p|div)\s[^>]*?class="(?:[^" ]* +)*error(?: +[^" ]*)*"

so any amount of other classes may precede or succede /error/.
Comment 1 Raimond Spekking 2008-10-09 11:46:24 UTC 
Applied with r41881 with 

<(?:strong|span|p|div)\s(?:[^\s>]*\s+)*?class="(?:[^"\s>]*\s+)*?error(?:\s[^">]*)?"

from my talk page: http://de.wikipedia.org/wiki/Benutzer_Diskussion:Raymond/Archiv_2008-2#.23iferror
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links