Last modified: 2008-09-04 15:18:32 UTC
Add a patrol module, action=patrol to the API.
*** Bug 15447 has been marked as a duplicate of this bug. ***
Created attachment 5267 [details] Proposed patch Patch implementing new action Parameters: title id token gettoken
Created attachment 5268 [details] Add RELEASE-NOTES
Created attachment 5269 [details] Uncomment the post-only stamement
(In reply to comment #4) > Created an attachment (id=5269) [details] > Uncomment the post-only stamement > * You don't need the title parameter, you don't need to create a Title and an Article and you don't need to check for their validity. You're not actually using any of these anywhere. An rcid is enough to patrol a change * The gettoken method for getting tokens is deprecated in favor of retrieving tokens through prop=info or prop=revisions. The old gettoken parameters are still there and won't be removed, of course (backwards compatibility), but we shouldn't be adding new ones. Patrol tokens should probably be added to list=recentchanges * Please use $wgUseRCPatrol instead of $GLOBALS['wgUseRCPatrol'], particularly because you do use $wgUser earlier on * The id parameter should be renamed to rcid and be specified as an integer * In the 'patrolnotenabled' message, please use "Patrolling _is_ not enabled on this wiki". That sounds a little anal, and maybe it is, but we're trying to avoid overly concise error messages * In the 'cantpatrol' message, "patrolling pages" is used, while we're really patrolling _changes_ (entries in the recentchanges table)
Created attachment 5282 [details] Improvements *Title parameter removed *Gettoken commented out *$wgUseRCPatrol and $wgUseNPPatrol enabled *id is now rcid, and an extra check added, checking if rcid is equal to int(rcid). *Disabled messages fixed. *s/pages/changes
Created attachment 5283 [details] Used the wrong diff
Created attachment 5284 [details] Sigh...new patch
Created attachment 5285 [details] Add rcid to allowed params
Quick note -- there's commented-out code in the latest version of the patch. If it's not needed, just take it out! :)
Created attachment 5286 [details] Remove comments If you wish, brion...
Modified version of patch applied in r40435, along with a split of the patrol code
