Last modified: 2008-07-14 14:38:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16783, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 14783 - Add "accesskey" to "Submit review" button
Add "accesskey" to "Submit review" button
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-07-10 18:22 UTC by Tim Landscheidt
Modified: 2008-07-14 14:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Landscheidt 2008-07-10 18:22:01 UTC 
At the moment, the "Submit review" button has no "accesskey" (like "l" for watch list, "h" for history, etc.). Therefore, e. g. on Konqueror the next free key is assigned which is different between pages in the main and template namespace and the image namespace (the latter do not have "Move" links & Co.).

It would be nice to add the accesskey "s" (like "sichten" or "sight") to the button (revreview-submit) to have a consistent UI in all namespaces.
Comment 1 Aaron Schulz 2008-07-10 18:45:00 UTC 
Done in r37542
Comment 2 Tim Landscheidt 2008-07-11 21:20:40 UTC 
Two more instances:

- The "Article"/"Draft"/"Talk" tabs (revision with unreviewed changes) have no accesskey for "Article" (should be "c") and none for "Draft". I'd propose "d" for the latter.
- Same goes for the diff page linked to by "compare" of "Draft/view article/compare" (same code?).
Comment 3 Aaron Schulz 2008-07-14 14:32:37 UTC 
'd' is for Delete :)
Comment 4 Aaron Schulz 2008-07-14 14:38:19 UTC 
Done in r37646. I left the diff alone though.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links