Last modified: 2008-10-25 03:07:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13984 - HTML code cleanup (#mw-revisiontag)
HTML code cleanup (#mw-revisiontag)
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
All All
: Lowest trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-05-06 15:33 UTC by Melancholie
Modified: 2008-10-25 03:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Melancholie 2008-05-06 15:33:27 UTC
Please replace
<span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'
			onclick='toggleRevRatings()' title='zeige/verstecke Details' >(+/-)</span>

<a id="mw-revisiontoggle" class="flaggedrevs_toggle" href="javascript:toggleRevRatings()" title="Zeige/verstecke Details">(+/-)</a>

as this is shorter. Then do not toggle style.display, but the link text (innerHTML) ["(+/-)" <> ""]
No need then for cursor:pointer anymore!

Furthermore either use " or ' ;-) As the whole rest of the HTML output uses /"/ I would use that. Trivial, but consistent.
Comment 1 Aaron Schulz 2008-05-06 15:40:32 UTC
visibility is cleaner. I'll look into consistent quote use
Comment 2 Danny B. 2008-05-15 09:53:53 UTC
Well, cursor: pointer; isn't supported by IE, thus some hack for cursor: hand; necessary if it can't be <a> instead of <span> which would simplify this a lot.
Comment 3 Aaron Schulz 2008-05-15 14:39:09 UTC
I'm seeing the hand over the +/- link in IE 7 at least.
Comment 4 Aaron Schulz 2008-05-16 12:54:30 UTC
Switched to <a> in r34919
Comment 5 Ilmari Karonen 2008-10-25 01:02:09 UTC
Unfortunately, it seems NoScript treats <a href="javascript:foo('bar')"> and <a href="#" onclick="foo('bar')"> exactly the same way.  So changing from the former to the latter won't actually fix the problem.
Comment 6 Danny B. 2008-10-25 01:06:18 UTC
MediaWiki should not accomodate to crappy Firefox extensions, but they should be fixed to run properly.

<a href="#" onclick="foo('bar')"> is the correct accessible way, how to deal with javascript links only.
Comment 7 Ilmari Karonen 2008-10-25 03:07:20 UTC
Sorry, wrong bug.  Comment #5 above should've been to bug 16073.

Note You need to log in before you can comment on or make changes to this bug.