Last modified: 2012-10-25 17:39:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15493, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13493 - Can't create thumbnail of images with a peculiar aspect ratio
Can't create thumbnail of images with a peculiar aspect ratio
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.13.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Ima...
:
Depends on:
Blocks: 41371
  Show dependency treegraph
 
Reported: 2008-03-24 18:31 UTC by Broken Arrow
Modified: 2012-10-25 17:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Broken Arrow 2008-03-24 18:31:54 UTC
Thumbnailing very tall and narrow images, whose width is only a few pixels (like the one above, 2 × 295 pixels) does not work in galleries. According to Brion, the code may be trying to scale to less than 1 pixel wide. Example:
http://commons.wikimedia.org/w/index.php?title=Special:NewImages&until=20080324144749
Comment 1 Brion Vibber 2008-03-24 20:49:41 UTC
The base problem is that MediaWiki tracks thumbnails by width, and here we're requesting a size that's not going to fit in the 120x120 box... The 1px-wide image will be ~148 pixels tall, so it has to back down a pixel to 0px... which is invalid.

(Note that the equivalent horizontal bar renders to a 120x120 box just fine, since we can request the exact desired width.)

Probably what we want to do here is take the 1px version, then if necessary scale it client-side to fit vertically.
Comment 2 Bryan Tong Minh 2011-03-12 20:34:15 UTC
Client side scaling for <1px images in either direction looks like the best solution to me.
Comment 3 Bryan Tong Minh 2012-10-25 17:39:37 UTC
This was fixed somewhere along the way.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links