Last modified: 2012-10-24 17:36:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15000, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13000 - Allow Blockedtext start with == heading ==
Allow Blockedtext start with == heading ==
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks: 18521
  Show dependency treegraph
Reported: 2008-02-12 19:13 UTC by Li-sung
Modified: 2012-10-24 17:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

line break before message Blockedtext (468 bytes, patch)
2008-02-12 19:13 UTC, Li-sung

Description Li-sung 2008-02-12 19:13:23 UTC
Created attachment 4645 [details]
line break before message Blockedtext

Message Blockedtext cannot start with == heading ==, it is rendered as "==".

I guess adding line break before message is inserted can fix this.
Comment 1 Brion Vibber 2008-02-25 22:24:35 UTC
Proposed patch is insufficient; these permission errors are formatted in such a way that they *need to* be treated as single lines.

If there's only one, it's wrapped in a <div>; multiples are wrapped in <li>s in a <ul> bullet list.

If it were correct to allow block formatting (such as headers), then the whole function needs to be ripped out and totally rewritten.
Comment 2 Krinkle 2010-05-29 22:31:57 UTC
That's probably a good idea then :D - since the few major wiki's I've checked all have headings, div's, tables and what not in MediaWiki:Blockedtext.

Comment 3 Krinkle 2010-05-29 22:33:28 UTC
Though the cause of the rendering not happening might not be the cause of the (absence of a) linebreak, since on those few major wiki's it is just fine.

See also where I have an issue that might be related.
Comment 4 db [inactive,noenotif] 2010-11-08 19:02:54 UTC
The newline from the patch was added in r50976. Is that a possible fix?
Comment 5 p858snake 2011-04-30 00:10:14 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 6 Sumana Harihareswara 2011-11-10 02:14:17 UTC
Li-sung, thanks for the patch.  Do you have time and interest in updating it and revising it in accordance with the suggestions you've received in comments?
Comment 7 Siebrand Mazeland 2012-10-24 17:36:39 UTC
The wanted newline is in the code now. Considering this issue closed.


2193                 if ( count( $errors ) > 1 ) {
2194                         $text .= '<ul class="permissions-errors">' . "\n";
2196                         foreach( $errors as $error ) {
2197                                 $text .= '<li>';
2198                                 $text .= call_user_func_array( array( $this, 'msg' ), $error )->plain();
2199                                 $text .= "</li>\n";
2200                         }
2201                         $text .= '</ul>';
2202                 } else {
2203                         $text .= "<div class=\"permissions-errors\">\n" .
2204                                         call_user_func_array( array( $this, 'msg' ), reset( $errors ) )->plain() .
2205                                         "\n</div>";
2206                 }

Note You need to log in before you can comment on or make changes to this bug.