Last modified: 2009-12-31 00:51:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14405, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 12405 - Move PngFix code to IEFixes.js
Move PngFix code to IEFixes.js
Status: RESOLVED DUPLICATE of bug 234
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-12-24 20:35 UTC by rememberthedot
Modified: 2009-12-31 00:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description rememberthedot 2007-12-24 20:35:31 UTC 
Please move the PngFix code from http://en.wikipedia.org/wiki/MediaWiki:Common.js to IEFixes.js. The code has become highly stable and flexible, and can be disabled on any wiki by adding "window.PngFixDisabled = true" to Mediawiki:Common.js.

Moving this fix to the main IEFixes.js has two advantages:
1. Decreased load time for English Wikipedia users who are not using IE
2. The fix would be applied on all wikis, avoiding the need to manually copy it to each one's Common.js

Feel free to change "PngFix" to "pngFix" and "PngFixDisabled" to "pngFixDisabled" if this better matches your naming conventions. I doubt very many users (if any) actually set PngFixDisabled, so it wouldn't cause many problems.
Comment 1 Antoine "hashar" Musso (WMF) 2008-08-28 21:17:08 UTC 
The IE6 fix is now at :
http://en.wikipedia.org/wiki/MediaWiki:Common.js/IE60Fixes.js

It can probably replaces fixalpha() in IEFixes.js
Comment 2 Guillaume Paumier 2009-12-31 00:51:17 UTC 
This piece of code seems to fix the issue reported in bug 234, so I'm going to merge these two. Feel free to undo this change if the assessment was erroneous.

*** This bug has been marked as a duplicate of bug 234 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links