Last modified: 2009-08-23 22:31:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13857, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 11857 - Protect Functionality for importImage.php Maintenance Script


Summary:	Protect Functionality for importImage.php Maintenance Script

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.12.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-11-02 17:33 UTC by Aaron Axelsen
Modified:	2009-08-23 22:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch File (1.61 KB, patch) 2007-11-02 17:34 UTC, Aaron Axelsen	Details
Patch File - Version 2 (1.80 KB, patch) 2007-11-02 18:45 UTC, Aaron Axelsen	Details
Patch for 1.13.0 (2.42 KB, patch) 2008-08-22 21:39 UTC, Aaron Axelsen	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Aaron Axelsen 2007-11-02 17:33:50 UTC

I have added the option to protect/unprotect images that are imported using the script.  The entire page can be viewed here: http://pastebin.modevia.com/150

I have attached a patch against the latest SVN trunk.

Comment 1 Aaron Axelsen 2007-11-02 17:34:50 UTC

Created attachment 4302 [details]
Patch File

Comment 2 Aaron Axelsen 2007-11-02 18:44:59 UTC

My ordering was off in the first patch, please look at version 2: http://pastebin.modevia.com/151

One other thing, is that you must specify an existing mediawiki user for this to work correctly.

Comment 3 Aaron Axelsen 2007-11-02 18:45:32 UTC

Created attachment 4303 [details]
Patch File - Version 2

Comment 4 Aaron Axelsen 2008-03-07 20:38:06 UTC

any updates on this?

Comment 5 Aaron Axelsen 2008-08-22 21:39:37 UTC

Created attachment 5208 [details]
Patch for 1.13.0

Comment 6 Niklas Laxström 2008-10-06 07:06:37 UTC

The validation of input looks a bit shaky:
$restrictions['move'] = $options['protect'];

Comment 7 Aaron Axelsen 2009-01-08 14:47:19 UTC

What kind of validation are you looking for?  I would really like to see this get committed to the source code.

Comment 8 Alexandre Emsenhuber [IAlex] 2009-08-23 22:31:49 UTC

this was added in r47964.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links