Last modified: 2010-05-15 15:33:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3163, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 1163 - Special:Undelete shows oldest revision not newest
Special:Undelete shows oldest revision not newest
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.4.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2004-12-23 06:46 UTC by Colin Pitts
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch against HEAD (480 bytes, patch)
2005-04-20 19:17 UTC, Mormegil 		Details
Patch against REL1_4_1 (471 bytes, patch)
2005-04-20 19:20 UTC, Mormegil 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Colin Pitts 2004-12-23 06:46:26 UTC 
Special:Undelete displays the oldest deleted revision not the newest.

This behavior is both counter-intuitive and backwards from the existing behavior.
Comment 1 Mormegil 2005-04-20 19:17:55 UTC 
Created attachment 438 [details]
Patch against HEAD

The bug is caused by a string passed instead of an array of options to
selectrow.
Comment 2 Mormegil 2005-04-20 19:20:38 UTC 
Created attachment 439 [details]
Patch against REL1_4_1
Comment 3 Brion Vibber 2005-04-21 07:27:38 UTC 
Applied with slight modification (include the limit; if there are many we only want one here).

Fix in CVS HEAD and REL1_4, will appear in 1.4.3 release

(Note that deletion is a bit borked in HEAD at the moment.)
Comment 4 Mormegil 2005-04-21 09:24:42 UTC 
(In reply to comment #3)
> Applied with slight modification (include the limit; if there are many we only
want one here).

Note that this is unnecessary, Database::selectRow specifies LIMIT 1
automatically ("select [one] row").
Comment 5 Brion Vibber 2005-04-21 09:45:08 UTC 
Ok, time to sleep before any more check-ins. :)

Removed the redundant clause. (It's harmless as it's overridden in selectRow(), not appended, but let's not 
needlessly multiply non-parsimonious elements.)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links