Last modified: 2009-03-18 23:31:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13213, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11213 - [edit] section links in printable version interfere with cut-and-paste of article text
[edit] section links in printable version interfere with cut-and-paste of art...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Arash Boostani
:
: 17810 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-06 16:33 UTC by Michael Burnham
Modified: 2009-03-18 23:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Burnham 2007-09-06 16:33:48 UTC
When copying headers from the printable version and pasting into another application, "[edit]" appears.

Here is a paste from the meta.wikimedia.org main page from the printable version.

...


2

    * The Thai Wikipedia has 30,000 registered users.

[edit] August 2007

30

    * The Turkish Wikipedia has reached 90,000 articles.
    * The Estonian Wikipedia has reached 40,000 articles.
    * The Bosnian Wikipedia has reached 20,000 articles.

...
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-09-09 23:31:59 UTC
This is an upstream issue.  Browsers should not include display:none elements in copy-and-pasted text if they intend to maintain fidelity with what the user sees.  Please complain to the maintainers of the browser you're using.  As for us, we aren't going to bend over backwards (and it would be a pretty big change) to support the marginal case of copying text in a broken browser: the links are removed from the version as printed, which is the sole point of the printable version.
Comment 2 Danny B. 2007-09-09 23:50:30 UTC
Edit links should not be present at all if such user's preference set. Hiding via CSS is just workaround which works only in visual browsers with CSS support and having it turned on.
Comment 3 Brion Vibber 2009-03-06 01:29:26 UTC
*** Bug 17810 has been marked as a duplicate of this bug. ***
Comment 4 Brion Vibber 2009-03-06 01:32:26 UTC
While we fancy devs tend to think of this as a silly complaint, it is one that hits real people doing perfectly reasonable things, and it's rather annoying to have to run about manually removing the links.

It is IMO not unreasonable to try to accommodate this... If we're not willing to change the parser output for printable mode (parser cache issues), it would at least be fairly trivial to drop in some JavaScript in wikibits.js which would trim them out, and would help the majority of people encountering this issue.
Comment 5 Brion Vibber 2009-03-06 01:33:05 UTC
This seems like a fun one for the usability crew... Arash, take a peek! :D
Comment 6 penubag 2009-03-06 01:50:38 UTC
Thank you brion! If you get this done, you'll have my personal gratitude. 
Comment 7 Arash Boostani 2009-03-18 23:31:46 UTC
Fixed in r48544

Rather than doing this after the page loads, via javascript, I made it so that those links don't get rendered at all in the printable version of the page. This means that the printable version will now be cached separately, which was not the case prior to this change.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links