Last modified: 2009-03-18 00:17:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13033, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11033 - EditPage assumes MediaWiki:Copyrightpage can't be external
EditPage assumes MediaWiki:Copyrightpage can't be external
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.15.x
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-08-23 00:10 UTC by Dan Jacobson
Modified: 2009-03-18 00:17 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2007-08-23 00:10:47 UTC
Let's discuss EditPage.php's
 $copywarn = "<div id=\"editpage-copywarn\">\n" .
	wfMsg( $wgRightsText ? 'copyrightwarning' : 'copyrightwarning2',
		'[[' . wfMsgForContent( 'copyrightpage' ) . ']]',
		$wgRightsText ) . "\n</div>";
which uses
   'copyrightwarning' => ... released under the $2 (see $1 for details)....

(Note the hardwired '[[', ']]' perhaps hackish looking code above.)

Well, it turns out if one makes e.g.,
$ GET 'http://radioscanningtw.jidanni.org/index.php?title=MediaWiki:Copyrightpage&action=raw'
      http://zh.wikipedia.org/w/index.php?title=Wikipedia:版权信息&variant=zh-tw
One will get ugly '[[1]]':
$ w3m -dump 'http://radioscanningtw.jidanni.org/index.php?title=User:Jidanni&action=edit&uselang=en' |fgrep [[1
     the GNU許可 (see [[1]] for details). If you don't want your writing to be

That's right, EditPage.php makes the big assumption that
MediaWiki:Copyrightpage can only be an internal link.
Therefore the outer [ and ] of [[1]] end up being not parsed as part
of the link... just page clutter. Also the inner [1] itself is
probably not flexible if one wants to make it show up differently.
Comment 1 Brion Vibber 2007-08-23 14:02:22 UTC
Yes, it's meant to be an internal link.
Comment 2 Dan Jacobson 2007-08-23 19:09:45 UTC
<Sniff>, all I wanted to do was make MediaWiki:Copyrightpage = $wgRightsUrl.

I suppose I did the best I could without resorting to fiddle with MediaWiki:Copyrightwarning.
Comment 3 Dan Jacobson 2009-03-18 00:17:56 UTC
For anybody reading looking for a workaround to Edit.php's hardwired
expecting of internal links ('[[' . wfMsgForContent( 'copyrightpage' ) . ']]'),
the workaround is to just make MediaWiki:Copyrightpage have:
   [http://bla... Googoo]
Sure it will be rendered "[[Googoo]]" instead of "Googoo", but it is better
than just "[1]".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links