Last modified: 2008-09-19 13:23:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10482 - install.php causes inclusion errors running upgrade.php
install.php causes inclusion errors running upgrade.php
Product: MediaWiki extensions
Classification: Unclassified
CheckUser (Other open bugs)
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch
Depends on:
  Show dependency treegraph
Reported: 2007-07-06 18:01 UTC by anaconda
Modified: 2008-09-19 13:23 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Trivial fix for inclusion error in install.php (433 bytes, patch)
2007-07-06 18:01 UTC, anaconda

Description anaconda 2007-07-06 18:01:44 UTC
Created attachment 3875 [details]
Trivial fix for inclusion error in install.php

install.php causes a PHP inclusion error if the extension is not in the $IP/extensions directory. Patch is attached.
Comment 1 Brion Vibber 2007-07-06 21:59:22 UTC
1) That would be a pretty broken system, with files in the wrong place. :)

2) Unspecified relative includes of this sort are extremely unreliable and should be avoided, as they frequently cause scripts to break when not run from a particular directory, and/or if the include path is being used straight (without the old hardcoding).

It's much preferable to use clear paths as they will continue to work when run from command line.

3) This install.php is, or will soon be, obsolete as the new system will run through the standard MW update.php.
Comment 2 Chad H. 2008-09-19 13:23:28 UTC
Seems fixed, as install.php makes use of MW_INSTALL_PATH. In addition, I _believe_ CU now uses the normal update.php, as Brion indicated a year ago that it would.

Note You need to log in before you can comment on or make changes to this bug.